Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile page is cut off with small display size #431

Closed
BenHenning opened this issue Nov 20, 2019 · 7 comments · Fixed by #3630
Closed

Profile page is cut off with small display size #431

BenHenning opened this issue Nov 20, 2019 · 7 comments · Fixed by #3630
Assignees
@Pranav-Bobde
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Ship Oppia on Android CLAM Team (deprecated -- please use n...

Comments

@BenHenning
Copy link
Sponsor Member

No description provided.

@BenHenning BenHenning changed the title Profile page is cut off with large display size Profile page is cut off with small display size Nov 20, 2019
@BenHenning
Copy link
Sponsor Member Author

@jamesxu0 is this going to be fixed with the remaining profile work?

@BenHenning BenHenning mentioned this issue Nov 30, 2019
Closed
29 tasks
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added this to Triage in Ship Oppia on Android via automation Jun 23, 2020
@BenHenning BenHenning added Type: Bug Priority: Essential This work item must be completed for its milestone. and removed Workstream: Finalize Prototype pt2 (20-30 Nov) labels Jun 23, 2020
@anandwana001
Copy link
Contributor

I checked on 480*800 hdpi. Could you please post a specific screenshot or configuration?

Screenshot_1594185195

@BenHenning
Copy link
Sponsor Member Author

@anandwana001 how does the profile list look (both in newcomer and existing user mode) under the same display settings? Also, what about all other profile pages? I don't remember which one had issues, but we should check all of them.

@anandwana001
Copy link
Contributor

Adding screenshot for reference.

What we need actually? -> In this particular case when a user has not added any profile once, both the items should be completely visible on the screen.

Screenshot

Nexus S
Screenshot_1595586090

@anandwana001 anandwana001 removed their assignment Jul 28, 2020
@anandwana001
Copy link
Contributor

For reference,
We are in discussion with Chantel regarding supporting the lower devices for mock

@BenHenning BenHenning modified the milestones: Alpha, Beta Aug 5, 2020
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 12, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta (Bugs & Fixes) in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@rt4914 rt4914 moved this from Beta (Bugs & Fixes) to High-fi Beta in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@Pranav-Bobde Pranav-Bobde mentioned this issue Aug 1, 2021
Merged
8 tasks
@rt4914
Copy link
Contributor

rt4914 commented Aug 4, 2021

@Pranav-Bobde Can you leave a comment on this issue mentioning you are working on it.

@Pranav-Bobde
Copy link
Contributor

working on it

Ship Oppia on Android automation moved this from Triage to Done Sep 10, 2021
rt4914 pushed a commit that referenced this issue Sep 10, 2021
@Pranav-Bobde
Fix #431: Fixed Profile Page Cut-Off For Small Display (#3630)
f56345c 
* Fixed profile page cut off in small display size

* removed redundant lines

* dimens for landscape xml added

* made suggested name change

* updated one wrong value in dimens

* made suggested changes

* made suggested changes according to PPT

* made suggested nit changes
CLAM Team (deprecated -- please use new board) automation moved this from [Beta] Low-fi & High-fi to Closed Sep 10, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pranav-Bobde Pranav-Bobde

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Ship Oppia on Android
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #431: Fixed Profile Page Cut-Off For Small Display Pranav-Bobde/oppia-android
5 participants
@rt4914 @BenHenning @anandwana001 @jamesxu0 @Pranav-Bobde