Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Pinview thirdparty library. #3855

Closed
veena14cs opened this issue Sep 28, 2021 · 3 comments · Fixed by #4041
Closed

Remove Pinview thirdparty library. #3855

veena14cs opened this issue Sep 28, 2021 · 3 comments · Fixed by #4041
Assignees
@deepanshu731
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@veena14cs
Copy link
Contributor

Older implementation of Pin Verification UI was using PinView library io_github_chaosleung_pinview which was not supporting RTL. To fix this we removed this library and created new UI as per the new mocks implemented in the PR #3684.

This library has to be removed from

BUILD.bazel
build.gradle
versions.bzl

Then update maven_intall.json file.
@justdvnsh
Copy link
Contributor

@veena14cs I'd like to work on this issue.

@veena14cs
Copy link
Contributor Author

Thanks @justdvnsh I will assign it to you.

@veena14cs veena14cs mentioned this issue Oct 6, 2021
Closed
4 tasks
@BenHenning
Copy link
Sponsor Member

De-assigning since #3884 was auto-closed from being stale. @justdvnsh if you're still working on this, please let us know and we can reassign this & reopen the PR.

@deepanshu731 deepanshu731 self-assigned this Dec 8, 2021
@deepanshu731 deepanshu731 mentioned this issue Dec 14, 2021
Merged
BenHenning pushed a commit that referenced this issue Jan 12, 2022
@deepanshu731
Fix #3855: Removed Pinview thirdparty library (#4041)
7a5b0bc 
* removed lib from build files

* Delete maven_install.json

* repin deps

* done something

* trial

* trial
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepanshu731 deepanshu731

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3855: Removed Pinview thirdparty library deepanshu731/oppia-android
4 participants
@BenHenning @veena14cs @justdvnsh @deepanshu731