Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to run app on API 19 because of Okhttp library #3853

Closed
rt4914 opened this issue Sep 28, 2021 · 1 comment · Fixed by #3910
Closed

Unable to run app on API 19 because of Okhttp library #3853

rt4914 opened this issue Sep 28, 2021 · 1 comment · Fixed by #3910
Assignees
@BenHenning
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
KitKat support

Comments

@rt4914
Copy link
Contributor

rt4914 commented Sep 28, 2021

Unable to run app on API 19 because of Okhttp library as it requires minimum of API 21.
@rt4914 rt4914 added this to To do in KitKat support via automation Sep 28, 2021
@anandwana001
Copy link
Contributor

Duplicate - #3740

@BenHenning BenHenning self-assigned this Oct 7, 2021
@BenHenning BenHenning mentioned this issue Oct 7, 2021
Merged
6 tasks
KitKat support automation moved this from To do to Done Oct 8, 2021
BenHenning added a commit that referenced this issue Oct 8, 2021
@BenHenning
Fix #3803, #3804, #3853, #3669, #3383: Add basic KitKat support in Ba…
9bf7365 
…zel (#3910)

* Initial commit for drawable->SVG conversion script.

At the moment, about ~40% of drawables can be successfully converted
(with some coordinate system inconsistencies for their gradients that
need to be corrected). Some other SVG constructs still need to be added
for the remaining drawables (such as groups & clip regions).

* Add basic KitKat support.

This includes:
- Defining KitKat-specific flavors
- Utilizing a manual main dex file list (minimized) so that the
  Bazel-built KitKat flavor of the app can start successfully
- Migrating all drawable usage over to compat-compatible so that vectors
  can load properly in the KitKat world (+ opted-in compatibility layer)
- Adding a missing permission that seems only needed on KitKat with
  WorkManager (but isn't unreasonable to request in general)

* Flavor updates & move main dex file.

* Fix alpha KitKat flavor.

* Remove script changes.

* Add regex checks + tests.

Lock vector compat call behind KitKat gate.

* Address TODOs.

* Fix broken tests (potentially round 1).

* Test fixes (round 2).

* Add new test suite for NetworkModule.

* Post-merge + lint fixes.

* Fixes & remove files post-merge.

The removed files were accidentally re-added upon merge.

* Fix broken instrumentation build.

This came from an unrelated previously merged PR.

* Fix syntax error in workflow script.

* Add codeowner for new file.

* Actually fix syntax mistake in workflow.

* Gradle build fixes.

The styles simplification comes from
https://stackoverflow.com/a/50854279/3689782. Apparently, Bazel is more
permissive about this sort of thing than Gradle, but it might have
actually been wrong before (i.e. this version seems more correct).

* Use deep fetch for binary build workflow.

The develop branch needs to also be pulled for building //:oppia dev now
since it uses a transformed manifest.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
No open projects
KitKat support
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3803, #3804, #3853, #3669, #3383: Add basic KitKat support in Bazel oppia/oppia-android
3 participants
@rt4914 @BenHenning @anandwana001