Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex checks fail for translations #3786

Closed
BenHenning opened this issue Sep 14, 2021 · 0 comments · Fixed by #3787
Closed

Regex checks fail for translations #3786

BenHenning opened this issue Sep 14, 2021 · 0 comments · Fixed by #3787
Assignees
@BenHenning
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.6 Release Block...

Comments

@BenHenning
Copy link
Member

The new regex checks introduced in #3754 are incorrectly failing for translatewiki (the pattern is set up incorrectly). See: #3687
@BenHenning BenHenning self-assigned this Sep 14, 2021
@BenHenning BenHenning added this to the Alpha MR3 milestone Sep 14, 2021
This was referenced Sep 14, 2021
Merged
Merged
BenHenning added a commit that referenced this issue Sep 14, 2021
@BenHenning
Fix #3786: Fix regex checks for translated strings (#3787)
2d47a87 
* Fix regex checks for translated strings.

Also, performance improvements for the regex check.

* Lint-ish fix.

* Add check for nested res subdirectories.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
0.6 Release Blockers (Alpha MR3)
Development

Successfully merging a pull request may close this issue.

Fix #3786: Fix regex checks for translated strings oppia/oppia-android
1 participant
@BenHenning