Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] High-fi Rotation animation need to support RTL #3651

Closed
veena14cs opened this issue Aug 6, 2021 · 0 comments · Fixed by #3652
Closed

[RTL] High-fi Rotation animation need to support RTL #3651

veena14cs opened this issue Aug 6, 2021 · 0 comments · Fixed by #3652
Assignees
@veena14cs
Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@veena14cs
Copy link
Contributor

The icon rotation animation needs to be reversed in Topic lesson. (This applies for HintsAndSolutionFragment too). Basically clockwise animation should be replaced with anti-clockwise in RTL and vice-versa.
@veena14cs veena14cs self-assigned this Aug 6, 2021
@veena14cs veena14cs added the Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. label Aug 6, 2021
@veena14cs veena14cs added this to the RTL Support milestone Aug 6, 2021
@veena14cs veena14cs mentioned this issue Aug 6, 2021
Merged
8 tasks
BenHenning pushed a commit that referenced this issue Aug 11, 2021
@veena14cs
Fix #3651: [RTL] High-fi rotation animation for icon in Topic lesson …
77ff836 
…and Hints and Solution (#3652)

* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* Update return_to_topic_button_item.xml

* Update return_to_topic_button_item.xml

* Fixed rotation animation for icon in Topic lesson and Hints and Solution

* Optimized code

* Update ViewBindingAdaptersTest.kt

* Fixed tests

* Fixed unwanted code changes

* Update accessibility_label_exemptions.textproto

* fixed nit
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
2 participants
@BenHenning @veena14cs