Introduce Lightweight Syncing Mechanism for Platform Parameters #3605
Assignees
Labels
Priority: Essential
This work item must be completed for its milestone.
Type: Task
A single task of work corresponding to a greater milestone. Generally corresponds to a single PR.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
Arjupta
added
Where: Infrastructure
Priority: Essential
8 tasks
BenHenning
pushed a commit
that referenced
this issue
Aug 20, 2021
* Added GaeModels + PlatformParameterService and its Mock * Trying to fix bazel check by adding dependency over data module * Changed the location of MockService to testing/network and of ServiceTest to data * Bazel changes for TestConstants alomng with moving these constants into new file * Nit change in the bazel package name * Adding platform parameter BUILD.bazel as a dependency in testing * Adding test_constants in testing/network BUILD.bazel and utility in testing/platformparameter BUILD.bazel * Suggested changes related to exemption file, renaming test constants and Gae models also adding test cases in Service test and documentation over Gae models * Nit change related to TODO issue number * Reverting to the original response structure from backend. Removed GaeModels and used a Map<String,Any> instead * Removed GaeModels from exemptions file & platform parameter from TEST_DEPS of testing module * Nit change for renaming test function * Nit change for adding named arguments * Suggested change for testing request query, new files for test constants and KDoc changes * Static checks and updating exemption file * Basic commit for introducing a Worker, WorkerFactory and WorkerInitializer * Including all the files related to Platform Parameter Worker. * SyncUp worker tests are running fine. Commented out Prod Platform Parameter Service Impl in Network Module * Added the tests for SyncUpWorkManagerInitializer * Introduced TestNetworkModule in the tests to remove the dependency from NetworkModule * Modified exemption file to exclude Worker Factory and Module * Added bazel dependency over PlatformParameterService and ContextExtensions * Added NetworkModule in all the tests under where WorkManagerConfigurationModule is used * Suggested nit changes * Added tests for MockPlatformParameterService * Added test files in the kdoc-exemption * Corrected the import statement for WorkManagerConfigurationModule * KDoc exemption related changes * Changed the worker test to include exception checking * Nit changes related to KDoc and BUILD.bazel * Nit change of Reference Url in PlatformParameterService * Nit changes related to KDoc, BUILD.bazel and WorkMangerConfigurationModule import * Added NetworkModule in MarkTopicsCompletedFragmentTest * Failing checks related to WorkManager imports and Bazel dependency over testing/network * Trying to fix Bazel failure * Nit changes in KDoc exemption file, BUILD.bazel and WorkManagerImport * Suggested Changes for new Param,TestCases and KDoc - New SyncUpTimePeriod Parameter - New Test Case for Empty Response in WorkerTests - Shifted SplashScreenWlecomeMsgServerValue to IntegrationTest - Few KDoc changes * Nit KDoc change + NetworkModule in TestComponent * Bazel reformating for lint check * Suggested change for KDoc, Refactor & DataProvider - Changed the Time Period Parameter Name - Made updatePlaformParameter to return a dataprovider - KDoc changes * Correcting the work manager imports for new files * Suggested Nit changes by Ben * More Nit changes * Adding the tests for DataProvider we get from update operation for platform parameter database * Nit KDoc changes * KDoc changes and deleting commented out code * Suggested changes for KDoc and VisibleForTesting functions * Added NetworkModule in ForceNetworkTypeTests * Add NetworkConnectionDebugUtilModule in domain/BUILD.bazel * Suggested Nit changes * Bazel check failure due to NetworkConfigProdModule * Adding NetworkConfigProdModule into domain tests * Adding NetworkConfigProdModule in StateFragmentTest * Added WorkManagerConfigurationModule in OppiaTestApplication * Injected baseUrl into SyncuUpWorkerTests * Correcting the imports in TestApplicationComponent
Arjupta
moved this from In progress
to Done
in GSoC 2021.4: Feature Flags & Platform Parameters
BenHenning
added
the
Z-ibt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Platform Parameter Worker and its Worker Factory Classes along with Work Manager Initializer and Worker Module
PlatformParameterSyncUpWorker
PlatformParameterSyncUpWorkerFactory
PlatformParameterSyncUpWorkerModule
PlatformParameterSyncUpWorkManagerInitializer
Note : This Issue will point to PR-2.2 and PR-2.3 (under PlatformParameter project) which are related to WorkManager Implementation. Hence for this Issue I have mentioned the target PR date to be of the PR-2.2 and Target completion Date to be of the PR-2.3.
Target PR date: 25 July 2021
Target completion date: 08 August 2021
The text was updated successfully, but these errors were encountered: