Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge topic_practice_subtopic.xml into single xml file #3586

Closed
rt4914 opened this issue Jul 27, 2021 · 3 comments · Fixed by #3835
Closed

Merge topic_practice_subtopic.xml into single xml file #3586

rt4914 opened this issue Jul 27, 2021 · 3 comments · Fixed by #3835
Assignees
@kritigupta45
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 27, 2021

Currently there are 4 versions of topic_practice_subtopic.xml file merge it into single xml file.

We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml file and use it accordingly.

Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
@rt4914 rt4914 added this to the Backlog milestone Jul 27, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 27, 2021
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Type: Improvement labels Jul 27, 2021
@rt4914 rt4914 moved this from Needs Triage to Backlog (things to organize into workstreams) in CLAM Team (deprecated -- please use new board) Jul 27, 2021
@kritigupta45
Copy link
Contributor

@rt4914 I would like to work on this issue, kindly assign it to me.

@rt4914
Copy link
Contributor Author

rt4914 commented Sep 24, 2021

@kritigupta45
Thank you for showing interested. Please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

@rt4914
Copy link
Contributor Author

rt4914 commented Sep 24, 2021

cc: @Arjupta

@kritigupta45 kritigupta45 mentioned this issue Sep 24, 2021
Merged
6 tasks
CLAM Team (deprecated -- please use new board) automation moved this from Backlog (things to organize into workstreams) to Closed Oct 3, 2021
rt4914 pushed a commit that referenced this issue Oct 3, 2021
@kritigupta45
Fix #3586: Merge topic_practice_subtopic.xml into a single xml file (#…
4171e0d 
…3835)

* merge topic_practice_subtopic xml files & create variables in dimens.xml file

* revert unnecessary changes

* modify files for mob-landscape view

* changes dimens.xml

* revert .idea file

* modify xml file for tablet mode
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kritigupta45 kritigupta45

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
No open projects
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3586: Merge topic_practice_subtopic.xml into a single xml file kritigupta45/oppia-android
3 participants
@rt4914 @BenHenning @kritigupta45