-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge topic_practice_fragment.xml into single xml file #3584
Labels
good first issue
This item is good for new contributors to make their pull request.
Priority: Nice-to-have
This work item is nice to have for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
I would like to work on this issue, kindly assign it to me. |
@kritigupta45 Any updates in this issue? If you facing any issues, please reach out to your mentor. Thanks. |
@rt4914 Apologies for the delay, I am working on this issue right now. |
@kritigupta45 Thanks. |
6 tasks
CLAM Team (deprecated -- please use new board)
automation
moved this from Backlog (things to organize into workstreams)
to Closed
Jan 18, 2022
rt4914
pushed a commit
that referenced
this issue
Jan 18, 2022
…gle xml file (#4022) * merge files & changes dimen files accordingly * resolve merge conflict * modified dimens file * nit fixes * change tablet files * sw600dp file changes
bhaktideshmukh
pushed a commit
to bhaktideshmukh/oppia-android
that referenced
this issue
Jan 25, 2022
…a single xml file (oppia#4022) * merge files & changes dimen files accordingly * resolve merge conflict * modified dimens file * nit fixes * change tablet files * sw600dp file changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
This item is good for new contributors to make their pull request.
Priority: Nice-to-have
This work item is nice to have for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Currently there are 4 versions of
topic_practice_fragment.xml
file merge it into single xml file.We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in
dimens.xml
file and use it accordingly.Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
The text was updated successfully, but these errors were encountered: