Merge story_fragment.xml into single xml file #3576
Assignees
Labels
good first issue
This item is good for new contributors to make their pull request.
Priority: Nice-to-have
This work item is nice to have for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
rt4914
added this to Needs Triage
in CLAM Team (deprecated -- please use new board)
via automation
rt4914
added
good first issue
rt4914
moved this from Needs Triage
to Backlog (things to organize into workstreams)
in CLAM Team (deprecated -- please use new board)
|
Can,I work on this? |
|
@shivambh12 any updates over the issue? |
|
@Arjupta I was out of station for some days. I will generate PR soon. |
shivambh12
added a commit
to shivambh12/oppia-android
that referenced
this issue
Nov 17, 2021
Removed story_fragment-land and story_fragment-sw600dp Applied Required Changes in dimens.xml
CLAM Team (deprecated -- please use new board)
automation
moved this from Backlog (things to organize into workstreams)
to Closed
Jan 7, 2022
rt4914
pushed a commit
that referenced
this issue
Jan 7, 2022
* Merge story_fragment.xml into single xml file #3576 Removed story_fragment-land and story_fragment-sw600dp Applied Required Changes in dimens.xml * Added layout-sw600dp/story_fragment.xml And Applied Required Changes to dimen.xml * Extra spaces removed and new values declared at bottom * Asked Changes Applied. * Asked Changes Apllied. * Asked Changes Added. * Nit Change
BenHenning
added
the
Z-ibt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently there are 3 versions of
story_fragment.xmlfile merge it into single xml file.We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in
dimens.xmlfile and use it accordingly.Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
The text was updated successfully, but these errors were encountered: