Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge promoted_story_card.xml into single xml file #3568

Closed
rt4914 opened this issue Jul 27, 2021 · 1 comment · Fixed by #3767
Closed

Merge promoted_story_card.xml into single xml file #3568

rt4914 opened this issue Jul 27, 2021 · 1 comment · Fixed by #3767
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 27, 2021

Currently there are 4 versions of promoted_story_card.xml file merge it into single xml file.

We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml file and use it accordingly.

Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
@rt4914 rt4914 added this to the Backlog milestone Jul 27, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 27, 2021
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Type: Improvement labels Jul 27, 2021
@rt4914 rt4914 moved this from Needs Triage to Backlog (things to organize into workstreams) in CLAM Team (deprecated -- please use new board) Jul 27, 2021
@bkaur-bkj
Copy link
Contributor

@rt4914 pls assign this issue to me.

@bkaur-bkj bkaur-bkj mentioned this issue Sep 4, 2021
Merged
6 tasks
CLAM Team (deprecated -- please use new board) automation moved this from Backlog (things to organize into workstreams) to Closed Sep 14, 2021
rt4914 pushed a commit that referenced this issue Sep 14, 2021
@bkaur-bkj
Fix #3568 merged the Promoted_story_card xmls (#3767)
ff485e9 
* merged the Promoted_story_card xmls

* dimens renamed

* dimen changed

* changed promoted_story_card_width to 280 dp

* removed the common attribute from dimen files
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
No open projects
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3568 merged the Promoted_story_card xmls bkaur-bkj/oppia-android
3 participants
@rt4914 @BenHenning @bkaur-bkj