Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge profile_progress_fragment.xml into single xml file #3563

Closed
rt4914 opened this issue Jul 27, 2021 · 4 comments · Fixed by #4113
Closed

Merge profile_progress_fragment.xml into single xml file #3563

rt4914 opened this issue Jul 27, 2021 · 4 comments · Fixed by #4113
Assignees
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 27, 2021

Currently there are 4 versions of profile_progress_fragment.xml file merge it into single xml file.

We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml file and use it accordingly.

Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.

@rt4914 rt4914 added this to the Backlog milestone Jul 27, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 27, 2021
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Type: Improvement labels Jul 27, 2021
@rt4914 rt4914 moved this from Needs Triage to Backlog (things to organize into workstreams) in CLAM Team (deprecated -- please use new board) Jul 27, 2021
@shakivhussain
Copy link

shakivhussain commented Oct 21, 2021

I would like to work on this, please assign me.

@FareesHussain
Copy link
Contributor

@shakivhussain are you available to pick this up?

@shubhanshu-coder
Copy link

can u assign this to me i am intersted in this . Also pl guide me how to setup

@bhaktideshmukh
Copy link
Contributor

@yash10019coder Hey! assign this to me.

bhaktideshmukh added a commit to bhaktideshmukh/oppia-android that referenced this issue Jan 19, 2022
bhaktideshmukh added a commit to bhaktideshmukh/oppia-android that referenced this issue Jan 19, 2022
bhaktideshmukh added a commit to bhaktideshmukh/oppia-android that referenced this issue Jan 20, 2022
CLAM Team (deprecated -- please use new board) automation moved this from Backlog (things to organize into workstreams) to Closed Jan 25, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
No open projects
6 participants