Merge options_without_drawer_activity.xml into single xml file #3554
Labels
good first issue
This item is good for new contributors to make their pull request.
Priority: Nice-to-have
This work item is nice to have for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
rt4914
added this to Needs Triage
in CLAM Team (deprecated -- please use new board)
via automation
rt4914
added
good first issue
rt4914
moved this from Needs Triage
to Backlog (things to organize into workstreams)
in CLAM Team (deprecated -- please use new board)
|
Hi @rt4914! I want to work on this issue. Please assign it to me. Out of the 3 versions of options_without_drawer_activity.xml, 2 of them are identical and the third one has a very different layout. |
|
This is layout-sw600dp/options_without_drawer_activity.xml This is the layout of layout/options_without_drawer_activity.xml which is same as layout-land/options_without_drawer_activity.xml
|
bhaktideshmukh
added a commit
to bhaktideshmukh/oppia-android
that referenced
this issue
Jan 9, 2022
There are 3 files with the same name, 2 of them are identical (now merged to a single file) and the third one has a different layout.
6 tasks
CLAM Team (deprecated -- please use new board)
automation
moved this from Backlog (things to organize into workstreams)
to Closed
Jan 27, 2022
rt4914
pushed a commit
that referenced
this issue
Jan 27, 2022
BenHenning
added
the
Z-ibt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently there are 3 versions of
options_without_drawer_activity.xmlfile merge it into single xml file.We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in
dimens.xmlfile and use it accordingly.Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
The text was updated successfully, but these errors were encountered: