Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge option_activity.xml into single xml file #3549

Closed
rt4914 opened this issue Jul 27, 2021 · 4 comments · Fixed by #4090
Closed

Merge option_activity.xml into single xml file #3549

rt4914 opened this issue Jul 27, 2021 · 4 comments · Fixed by #4090
Assignees
@bhaktideshmukh
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 27, 2021

Currently there are 3 versions of option_activity.xml file merge it into single xml file.

We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml file and use it accordingly.

Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Type: Improvement labels Jul 27, 2021
@rt4914 rt4914 added this to the Backlog milestone Jul 27, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 27, 2021
@rt4914 rt4914 moved this from Needs Triage to Backlog (things to organize into workstreams) in CLAM Team (deprecated -- please use new board) Jul 27, 2021
@bhaktideshmukh
Copy link
Contributor

Hi @rt4914 Please assign this one as well! Thanks.

Here in option_activity.xml out of 3 versions, 2 of them are identical and third one has different layout.

@bhaktideshmukh
Copy link
Contributor

This is the layout of layout-sw600dp/option_activity.xml

Screenshot from 2022-01-09 22-39-47

@bhaktideshmukh
Copy link
Contributor

This is the layout of layout-land/option_activity.xml which is same as that of layout/option_activity.xml

Screenshot from 2022-01-09 22-40-11

bhaktideshmukh added a commit to bhaktideshmukh/oppia-android that referenced this issue Jan 9, 2022
@bhaktideshmukh
Fix oppia oppia#3549 Merge option_activity.xml
af35362 
6
@bhaktideshmukh
Copy link
Contributor

There are 3 files with the same name, 2 of them are identical
(now merged to a single file) and the third one has a different
layout.

Screenshot from 2022-01-09 22-43-41

bhaktideshmukh added a commit to bhaktideshmukh/oppia-android that referenced this issue Jan 10, 2022
@bhaktideshmukh
Fix oppia#3549 Merge option_activity.xml
51ec761
@bhaktideshmukh bhaktideshmukh mentioned this issue Jan 17, 2022
Merged
6 tasks
CLAM Team (deprecated -- please use new board) automation moved this from Backlog (things to organize into workstreams) to Closed Jan 17, 2022
rt4914 pushed a commit that referenced this issue Jan 17, 2022
@bhaktideshmukh
Fix #3549 Merge option_activity.xml (#4090)
bfaa7a3
bhaktideshmukh added a commit to bhaktideshmukh/oppia-android that referenced this issue Jan 25, 2022
@bhaktideshmukh
Fix oppia#3549 Merge option_activity.xml (oppia#4090)
09afb0c
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhaktideshmukh bhaktideshmukh

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
No open projects
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3549 Merge option_activity.xml bhaktideshmukh/oppia-android
3 participants
@rt4914 @BenHenning @bhaktideshmukh