Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename concept_card dimens properly #3530

Closed
deepanshu731 opened this issue Jul 27, 2021 · 1 comment · Fixed by #3645
Closed

Rename concept_card dimens properly #3530

deepanshu731 opened this issue Jul 27, 2021 · 1 comment · Fixed by #3645
Assignees
@rishidyno
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@deepanshu731
Copy link
Contributor

In dimens.xml file, Rename all the dimens of concept card fragment, according to proper convention like
concept_card_explanation_text_marginEnd(wrong convention) -> concept_card_explanation_text_margin_end(right convention)

Note: As you change the dimens.xml file, accordingly also change the concept_card XML file
@deepanshu731 deepanshu731 mentioned this issue Jul 27, 2021
Merged
@rishidyno
Copy link
Contributor

@prayutsu Please assign me this issue

@rishidyno rishidyno mentioned this issue Aug 4, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Aug 5, 2021
@rishidyno
Fix #3530: Rename concept card fragment dimens properly (#3645)
2054a1a 
* merge topic practice footer view from 4 to 3

* added removed file 😅

* added removed file 😅

* renamed `concept_card_fragment.xml` dimens properly

* Delete shelved.patch

* Delete Uncommitted_changes_before_Update_at_8_4_2021_11_37_PM__Default_Changelist_.xml
rt4914 pushed a commit that referenced this issue Aug 30, 2021
@bkaur-bkj
Fix #3530: Merge home fragments (#3737)
fc2e4ba 
* changes

* final changes

* task done

* changes made

* added endline in .idea files

* deleted empty git file
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishidyno rishidyno

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3530: Rename concept card fragment dimens properly
3 participants
@BenHenning @deepanshu731 @rishidyno