Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] High-fi Add support for RTL in binding adapters. #3451

Closed
veena14cs opened this issue Jul 9, 2021 · 0 comments · Fixed by #3452
Closed

[RTL] High-fi Add support for RTL in binding adapters. #3451

veena14cs opened this issue Jul 9, 2021 · 0 comments · Fixed by #3452
Assignees
@veena14cs
Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@veena14cs
Copy link
Contributor

Exploration content and feedback views needs RTL support.
screenshot
@veena14cs veena14cs added the Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. label Jul 9, 2021
@veena14cs veena14cs added this to the RTL Support milestone Jul 9, 2021
@veena14cs veena14cs self-assigned this Jul 9, 2021
@veena14cs veena14cs mentioned this issue Jul 9, 2021
Merged
8 tasks
@veena14cs veena14cs changed the title [RTL] High-fi Exploration content and feedback. [RTL] High-fi Add support for RTL in binding adapters. Jul 9, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 11, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta in CLAM Team (deprecated -- please use new board) Jul 11, 2021
@rt4914 rt4914 moved this from Beta (Features & Tasks) to RTL in CLAM Team (deprecated -- please use new board) Jul 12, 2021
CLAM Team (deprecated -- please use new board) automation moved this from [Alpha MR3] RTL to Closed Aug 9, 2021
BenHenning added a commit that referenced this issue Aug 9, 2021
@veena14cs @BenHenning @anandwana001
[RunAllTests] Fix #3451: [RTL] High-fi Add support for RTL in binding…
1405da8 
… adapters (#3452)

* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* Update return_to_topic_button_item.xml

* Update return_to_topic_button_item.xml

* Added check if RTL is enabled

* Fixed spacing

* fixed nit issues

* optimized code

* Added testcases

* removed unused imports

* corrected spacing

* Update StateAssemblerPaddingBindingAdapters.java

* updated scripts

* fixed spacing issue

* Update ActivityComponent.kt

* Update StateAssemblerPaddingBindingAdaptersTest.kt

* Update MarginBindingAdapters.java

* fixed nit changes

* Update app/src/main/res/layout/test_margin_bindable_adapter_activity.xml

Co-authored-by: Ben Henning <[email protected]>

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/MarginBindableAdaptersTest.kt

Co-authored-by: Ben Henning <[email protected]>

* added helper methods

* added helper methods

* Update MarginBindingAdapters.java

* fixed issues

* Update StateAssemblerMarginBindingAdaptersTest.kt

* Update MarginBindingAdapters.java

* Update ActivityComponent.kt

* Update ActivityComponent.kt

* Update ActivityComponent.kt

* Update ActivityComponent.kt

* used hardcoded dimens

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/StateAssemblerMarginBindingAdaptersTest.kt

Co-authored-by: Ben Henning <[email protected]>

* fixed nit

* optimized code

* fixed lint issues

* fixed margin binding adapters tests

* Update MarginBindingAdapters.java

* Fixed tests

* reverted config changes

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/StateAssemblerPaddingBindingAdaptersTest.kt

Co-authored-by: Akshay Nandwana <[email protected]>

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/StateAssemblerPaddingBindingAdaptersTest.kt

Co-authored-by: Akshay Nandwana <[email protected]>

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/StateAssemblerPaddingBindingAdaptersTest.kt

Co-authored-by: Akshay Nandwana <[email protected]>

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/StateAssemblerPaddingBindingAdaptersTest.kt

Co-authored-by: Akshay Nandwana <[email protected]>

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/MarginBindableAdaptersTest.kt

Co-authored-by: Akshay Nandwana <[email protected]>

* fixed changes

* created common function in utils

* opyimized and fixed issues

* fixed empted file issue

* Removed conversion function

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* added test file in Bazel and library in Test_deps

* Update BUILD.bazel

* removed test files

* fixed suggested changes

* Update AndroidManifest.xml

* Added comments

* Update BUILD.bazel

* Update BUILD.bazel

* fixed kdoc

* Added kdoc where required

* Added kdoc

* Update StateAssemblerPaddingBindingAdaptersTest.kt

* Update StateAssemblerPaddingBindingAdaptersTest.kt

* Update accessibility_label_exemptions.textproto

* Trigger Build

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/MarginBindingAdaptersTest.kt

Co-authored-by: Ben Henning <[email protected]>

* fixed block comment and updated bazel

* Update BUILD.bazel

* Update app/src/sharedTest/java/org/oppia/android/app/databinding/StateAssemblerPaddingBindingAdaptersTest.kt

Co-authored-by: Ben Henning <[email protected]>

* Update StateAssemblerPaddingBindingAdaptersTest.kt

* Update BUILD.bazel

* Update BUILD.bazel

Co-authored-by: Ben Henning <[email protected]>
Co-authored-by: Akshay Nandwana <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
2 participants
@BenHenning @veena14cs