Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProfileEdit toggle radio buttons by clicking on the complete item #3410

Closed
rt4914 opened this issue Jul 5, 2021 · 0 comments · Fixed by #3409
Closed

ProfileEdit toggle radio buttons by clicking on the complete item #3410

rt4914 opened this issue Jul 5, 2021 · 0 comments · Fixed by #3409
Assignees
@rt4914
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 5, 2021 •
edited
Loading

Describe the bug
Make the radio button with text a clickable to toggle the radio button (Allow Download Access) in the ProfileEdit

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'ProfileEdit '
  2. Click on Text on the left of radio button
  3. See that the radio button is not changed

Expected behavior
Toggle radio button by clicking on its corresponding text.

Similar to #3131
@rt4914 rt4914 added this to the Beta milestone Jul 5, 2021
@rt4914 rt4914 added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Status: In implementation labels Jul 5, 2021
@rt4914 rt4914 self-assigned this Jul 5, 2021
@rt4914 rt4914 changed the title Admin Controls toggle radio buttons by clicking on the complete item ProfileEdit toggle radio buttons by clicking on the complete item Jul 5, 2021
@rt4914 rt4914 mentioned this issue Jul 5, 2021
Merged
8 tasks
anandwana001 pushed a commit that referenced this issue Jul 5, 2021
@rt4914
Fix #3410: Merged Switch click with TextViews in ProfileEditActivity (#…
fb84577 
…3409)

* Merged switch click with TextViews in Profile Edit

* Added tests

* Added more tests

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3410: Merged Switch click with TextViews in ProfileEditActivity oppia/oppia-android
2 participants
@rt4914 @BenHenning