Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] High-fi Recently- Played Activity List #3406

Closed
veena14cs opened this issue Jul 4, 2021 · 0 comments · Fixed by #3466
Closed

[RTL] High-fi Recently- Played Activity List #3406

veena14cs opened this issue Jul 4, 2021 · 0 comments · Fixed by #3466
Assignees
@veena14cs
Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@veena14cs
Copy link
Contributor

Recently- Played Activity needs RTL support

screenshot
@veena14cs veena14cs added the Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. label Jul 4, 2021
@veena14cs veena14cs added this to the RTL Support milestone Jul 4, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 11, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta in CLAM Team (deprecated -- please use new board) Jul 11, 2021
@rt4914 rt4914 moved this from Beta (Features & Tasks) to RTL in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@veena14cs veena14cs mentioned this issue Jul 12, 2021
Merged
8 tasks
@veena14cs veena14cs self-assigned this Jul 25, 2021
CLAM Team (deprecated -- please use new board) automation moved this from [Alpha MR3] RTL to Closed Aug 12, 2021
veena14cs added a commit that referenced this issue Aug 12, 2021
@veena14cs @BenHenning
Fix #3406: [RTL] High-fi Recently- Played Activity List (#3466)
86d0d1f 
* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* Update return_to_topic_button_item.xml

* Update return_to_topic_button_item.xml

* fix rtl support in ongoing story card

* Update ongoing_story_card.xml

* Update MarginBindingAdapters.java

* Update OngoingStoryViewModel.kt

* Update MarginBindingAdapters.java

* Update OngoingListAdapter.kt

* Update OngoingListAdapter.kt

* added testcases

* Fixed testcases

* Update RecentlyPlayedFragmentTest.kt

* Update app/src/sharedTest/java/org/oppia/android/app/home/RecentlyPlayedFragmentTest.kt

Co-authored-by: Ben Henning <[email protected]>

* Update RecentlyPlayedFragmentTest.kt

* fixed nits

* Update BUILD.bazel

* Update BUILD.bazel

* Update RecentlyPlayedFragmentTest.kt

Co-authored-by: Ben Henning <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3406: [RTL] High-fi Recently- Played Activity List veena14cs/oppia-android
2 participants
@BenHenning @veena14cs