Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge OppiaTestRule and AccessibilityTestRule #3351

Closed
rt4914 opened this issue Jun 21, 2021 · 7 comments · Fixed by #4025
Closed

Merge OppiaTestRule and AccessibilityTestRule #3351

rt4914 opened this issue Jun 21, 2021 · 7 comments · Fixed by #4025
Assignees
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jun 21, 2021

Merge OppiaTestRule and AccessibilityTestRule in OppiaTestRule

Once done, run all test cases on Espresso and post screenshot displaying all tests are passing on Pixel 3 XL.

@rt4914 rt4914 added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Project stage: not started labels Jun 21, 2021
@rt4914 rt4914 added this to the Backlog milestone Jun 21, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 11, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta in CLAM Team (deprecated -- please use new board) Jul 11, 2021
@rt4914 rt4914 moved this from Beta (Features & Tasks) to A11Y Basic in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@vrajdesai78
Copy link
Contributor

I am getting this error while running OppiaTestRule without merging it with AccessbilityTestRule. I am using windows 11 and arctic Fox android studio
image

@rt4914
Copy link
Contributor Author

rt4914 commented Dec 2, 2021

@vrajdesai78 OppiaTestRule is actually not a test. Instead its a rule which we use in different test files. You cannot run it as a test.

@vrajdesai78
Copy link
Contributor

Okay so how can I check that my merged test cases are passing

@yash10019coder
Copy link
Contributor

@vrajdesai78 please run your test case file rather then running the test case rule

@vrajdesai78
Copy link
Contributor

@yash10019coder sorry I am not getting how to run the test case file. Can you please help me out

@yash10019coder
Copy link
Contributor

Hi @vrajdesai78 please make a PR for this issue.

@vrajdesai78
Copy link
Contributor

image

I am getting this error while building gradle.

CLAM Team (deprecated -- please use new board) automation moved this from [Beta MR1] A11Y Basic to Closed Jan 25, 2022
BenHenning pushed a commit that referenced this issue Jan 25, 2022
* Tests added in OppiaTestRule from AccessbilityTestRule

* Optimized code in OppiaTestRule

* Optimized imports in OppiaTestRule

* AccessbilityTestRule file deleted

* Revert "AccessbilityTestRule file deleted"

This reverts commit e6df4eb.

* AccessbilityTestRule replaced with OppiaTestRule in some files

* OppiaTestRule added in remaining files

* AccessbilityTestRule file deleted

* klint issue fixed for some files

* Revert "AccessbilityTestRule file deleted"

This reverts commit 8f9532f.

* klint fixed for single activity to check

* klint fixed for some files

* klint issue fixed

* Imports optimized

* Removed blank line from HomeActivityTest

* AccessibilityTestRule File Deleted

* Fixed tests passing on removing DisableAccessibilityTest

* Revert "AccessibilityTestRule File Deleted"

This reverts commit 1566b0d.

* Revert "Fixed tests passing on removing DisableAccessibilityTest"

This reverts commit fe3b0f8.

* AccessibilityTest File Deleted

* Fixed error in OppiaTestRule

* Fixed klint issue

* Changed variables in OppiaTestRule

* Fixed klint issue in OppiaTestRule

* Klint space issue fixed

* AccessibilityTestRule placed inside when condition
bhaktideshmukh pushed a commit to bhaktideshmukh/oppia-android that referenced this issue Jan 25, 2022
…pia#4025)

* Tests added in OppiaTestRule from AccessbilityTestRule

* Optimized code in OppiaTestRule

* Optimized imports in OppiaTestRule

* AccessbilityTestRule file deleted

* Revert "AccessbilityTestRule file deleted"

This reverts commit e6df4eb.

* AccessbilityTestRule replaced with OppiaTestRule in some files

* OppiaTestRule added in remaining files

* AccessbilityTestRule file deleted

* klint issue fixed for some files

* Revert "AccessbilityTestRule file deleted"

This reverts commit 8f9532f.

* klint fixed for single activity to check

* klint fixed for some files

* klint issue fixed

* Imports optimized

* Removed blank line from HomeActivityTest

* AccessibilityTestRule File Deleted

* Fixed tests passing on removing DisableAccessibilityTest

* Revert "AccessibilityTestRule File Deleted"

This reverts commit 1566b0d.

* Revert "Fixed tests passing on removing DisableAccessibilityTest"

This reverts commit fe3b0f8.

* AccessibilityTest File Deleted

* Fixed error in OppiaTestRule

* Fixed klint issue

* Changed variables in OppiaTestRule

* Fixed klint issue in OppiaTestRule

* Klint space issue fixed

* AccessibilityTestRule placed inside when condition
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

4 participants