Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] High-fi Selection Interaction View #3348

Closed
veena14cs opened this issue Jun 20, 2021 · 1 comment · Fixed by #3349 or #3395
Closed

[RTL] High-fi Selection Interaction View #3348

veena14cs opened this issue Jun 20, 2021 · 1 comment · Fixed by #3349 or #3395
Assignees
@veena14cs
Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@veena14cs
Copy link
Contributor

veena14cs commented Jun 20, 2021 •
edited
Loading

Exploration Player

  • Selecteion Interaction view needs to support RTL.

screenshot
@veena14cs veena14cs self-assigned this Jun 20, 2021
@veena14cs veena14cs mentioned this issue Jun 20, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Jun 23, 2021
@veena14cs
Fix #3348: [RTL] High-fi Selection Interaction View (#3349)
0be0815 
* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* fixed itemselection

* used margin instead of padding

* Update selection_interaction_item.xml
@veena14cs veena14cs reopened this Jun 30, 2021
@veena14cs
Copy link
Contributor Author

There is still some flakiness in the UI, so reopening the issue.

@veena14cs veena14cs added the Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. label Jun 30, 2021
@veena14cs veena14cs added this to the RTL Support milestone Jun 30, 2021
@veena14cs veena14cs mentioned this issue Jun 30, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Jul 3, 2021
@veena14cs
Fix #3348: [RTL] High-fi Selection Interaction View (#3395)
7fabb50 
* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* fixed itemselection

* used margin instead of padding

* Update selection_interaction_item.xml

* Update return_to_topic_button_item.xml

* Update return_to_topic_button_item.xml

* fixed padding

* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* used margin instead of padding

* Update selection_interaction_item.xml

* fixed padding

* Update selection_interaction_item.xml

* fixed padding conflict
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
2 participants
@BenHenning @veena14cs