Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce UI for Force Network Type #3309

Closed
yashraj-01 opened this issue Jun 11, 2021 · 0 comments · Fixed by #3502
Closed

Introduce UI for Force Network Type #3309

yashraj-01 opened this issue Jun 11, 2021 · 0 comments · Fixed by #3502
Assignees
@yashraj-01
Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
GSoC 2021.1: Developer Options Menu

Comments

@yashraj-01
Copy link
Contributor

yashraj-01 commented Jun 11, 2021 •
edited
Loading

Introduce UI for Force Network Type screen.
Mock link: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/8ae1a60e-7f6d-4b7b-b741-469bb80007b9/

Target PR date: 2021-07-19
Target completion date: 2021-07-27
@yashraj-01 yashraj-01 added Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Jun 11, 2021
@yashraj-01 yashraj-01 added this to the GSoC 2021.1: Milestone 2 milestone Jun 11, 2021
@yashraj-01 yashraj-01 self-assigned this Jun 11, 2021
@yashraj-01 yashraj-01 moved this from To do to In progress in GSoC 2021.1: Developer Options Menu Jun 28, 2021
@yashraj-01 yashraj-01 moved this from In progress to To do in GSoC 2021.1: Developer Options Menu Jul 1, 2021
@yashraj-01 yashraj-01 mentioned this issue Jul 18, 2021
Merged
8 tasks
@yashraj-01 yashraj-01 moved this from To do to In progress in GSoC 2021.1: Developer Options Menu Jul 18, 2021
anandwana001 pushed a commit that referenced this issue Aug 18, 2021
@yashraj-01
Fix #3309 and #3311: Implement Force Network Type Feature (#3502)
5d71407 
* Introduced initial UI for force network type screen

* Introduced prod and debug NetworkConnectionUtil

* Fixed bazel build failure

* Fixed app layer tests

* Fixed domain layer tests

* Fixed testing layer tests

* Fixed util layer tests

* Introduced prod and debug tests for NetworkConnectionUtil

* Nit fixes

* Renamed files

* Fixed failing domain layer tests on bazel

* Fixed failing utility layer tests on Bazel

* Added named arguments and other fixes

* Introduced a separate NetworkConnectionTestUtil

* Fixed failing tests

* Moved setNetworkInfo to companion object

* Added test for NetworkConnectionTestUtil

* Changes to BUILD.bazel files and tests. Mostly nits.

* Moved NetworkConnectionTestUtil and its Test to networking package

* Renamed debug and prod util

* Added tests for modules

* Nit fixes

* Added missing KDocs

* Removed redundant kdoc exemption

* Implemented force network type feature

* Added tests for DeveloperOptionsFragmentTest

* Introduced ForceNetworkTypeActivityTest and ForceNetworkTypeTestActivity

* Introduced ForceNetworkTypeFragmentTest

* Added test file exemptions

* Added accessibility label exemption

* Added missing KDocs

* Bazel nit

* Created dedicated local test targets for test/networking

* Removed extra checks and updated test cases accordingly

* Migrated tests to networking package

* Made test util inject

* Updated test util test

* Removed kdocs from test files

* Nit fix

* Nit fix

* bazel nit fix

* Nit fix

* fixed bazel lint

* Removed common test deps

* moved networking test util and its test to testing module

* bazel nit fix

* Moved activity and fragment tests to forcenetworktype package

* Nit fixes

* Used string instead of enum names

* Fixed failing static checks

* Fixed failing test

* nit fix

* Removed redundant kdoc exemption

* Made NetworkConnectionDebugUtil optional

* Fixed tests

* fixed bazel build and added TODOs

* Added Kdocs and test file exemptions

* Added network util module in test file

* Added debug util module

* fixed bazel failure

* renamed connection status

* Nit fix

* introduced oppia_debug_visibility

* added TODO

* fixed incorrect connection status

* used Guava's optional instead of java8
@yashraj-01 yashraj-01 moved this from In progress to Done in GSoC 2021.1: Developer Options Menu Aug 18, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashraj-01 yashraj-01

Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
GSoC 2021.1: Developer Options Menu
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3309 and #3311: Implement Force Network Type Feature oppia/oppia-android
2 participants
@BenHenning @yashraj-01