Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logic for marking stories completed #3305

Closed
yashraj-01 opened this issue Jun 11, 2021 · 0 comments · Fixed by #3445
Closed

Implement logic for marking stories completed #3305

yashraj-01 opened this issue Jun 11, 2021 · 0 comments · Fixed by #3445
Assignees
@yashraj-01
Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@yashraj-01
Copy link
Contributor

yashraj-01 commented Jun 11, 2021 •
edited
Loading

Implement logic for marking stories completed.

Target PR date: 2021-07-01
Target completion date: 2021-07-05
@yashraj-01 yashraj-01 added Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Jun 11, 2021
@yashraj-01 yashraj-01 added this to the GSoC 2021.1: Milestone 1 milestone Jun 11, 2021
@yashraj-01 yashraj-01 self-assigned this Jun 11, 2021
This was referenced Jul 3, 2021
Merged
Merged
@yashraj-01 yashraj-01 linked a pull request Jul 8, 2021 that will close this issue
Fix #3303, #3305 and #3306: Implement logic to modify lesson progress #3445
Merged
8 tasks
Sarthak2601 pushed a commit that referenced this issue Jul 11, 2021
@yashraj-01
Fix #3303, #3305 and #3306: Implement logic to modify lesson progress (…
d685571 
…#3445)

* Implement Developer Options Starter

* Fix lint issues

* Implement Developer Options Menu Item in Nav Drawer

* Fix lint issues

* Added Kdoc. abstract class -> interface

* Added tests for Developer Options menu item

* Fixed lint issues

* Introduced ApplicationComponentForDevMode

* Added KDocs and fixed lint issues

* Added test to check unavailibility of Dev Options menu item when not in dev mode

* Added initial test for DeveloperOptionsActivity. Added KDocs. Fixed lint issues

* Introduced DebugApplicationComponent

* Implement developer options menu ui

* Modified way of passing data to recycler view

* removed unnecessary isMultipane boolean

* added view models to app/BUILD.bazel

* Added tests for DeveloperOptionsActivityTest

* Fixed lint issues

* Corrected key mismatch error. Changed isDevMode to isDebugMode. Nit fixes

* Fixed Robolectric test for NavigationDrawerActivityTest

* Updated developer_options_fragment layout

* Added test for hints switch

* Added eof. Changed dev mode to debug mode

* Initial progress on UI of MarkChaptersCompleted

* Fixed lint issues

* Fixed populating recyclerview

* Fixed lint issues

* Removed unnecessary lastLoadedFragment flag

* fixed lint issues

* Added dependencies to app/BUILD.bazel

* Corrected imports

* Removed unnecessary code from DeveloperOptionsActivityTest

* Modified approach for Application Components

* nit fix

* nit fix

* Implemented UI of MarkStoriesCompleted

* Implemented UI of MarkTopicsCompleted

* Added tests and Kdocs + nit fixes

* Code reformating

* Separated dev and prod tests for NavigationDrawerActivityTest

* Added tests to check intents in DeveloperOptionsActivityTest

* Added tests for MarkChaptersCompletedActivityTest

* Added tests for MarkStoriesCompletedActivityTest

* Add tests for MarkTopicsCompletedActivityTest

* nit fix

* Renamed NavigationDrawerActivityDevTest to NavigationDrawerActivityDebugTest

* nit fixes. created helper functions

* Moved starter to devoptions

* Moved starter to devoptions

* nit fix

* Added TODOs

* Added named arguments

* Arranged activity titles in app/strings.xml

* Removed unnecessary code. Nit fixes

* Added accessiblity test rule. Modified UI for the same

* Nit fix

* Created ModifyLessonProgressController

* Added TODO

* Added Kdoc to DeveloperOptionsViewModel

* Added KDocs

* Added method to getAllStoriesWithProgress

* Modified approach to get chapter list with progress

* Added tests related to all stories in ModifyLessonProgressControllerTest

* Added check if completed functions and tests for the same

* Added isCompleted flag to topi and story view models

* Nit fixes

* Nit changes in strings.xml

* Added KDocs + nit fixes

* Corrected imports in test files

* Fixed cobine topi and topicProgress function

* Implemented topic selection logic

* Implemented story selection logic

* Nit fixes

* Added disabled checkbox color

* Changed controller method to return map of stories and topic id. Changed from nested recycler view to MultiType recycler view in MarkChaptersCompleted

* Fixed recycler view crashing

* Implemented all check for MarkChaptersCompleted

* Corrected tests in ModifyLessonProgressControllerTest

* Nit fixes

* Added configChange tests in DeveloperOptionsActivityTest. Corrected tests in MarkChapters/Stories/TopicsCompletedActivityTest

* Added more tests to MarkChaptersCompletedActivityTest

* Changed UI according to accessibilityTestRule

* Modified UI according to accessibilityTestRule for stories and topics as well

* Moved ModifyLessonProgressController to devoptions package

* Nits and kdocs

* Fixed bazel build failure

* Added more tests for MarkStoriesCompleted

* Added more tests for MarkTopicsCompleted

* Added TODOs and nit fixes

* Modifed chapters recycler view interaction logic

* updated Kdocs. Nit fixes

* Code refactor for topics and stories

* Code refactored for chapters

* Implemented mark topics completed feature

* Implemented logic to mark stories completed

* Fixed bazel build failure

* Implement logic to mark chapters completed

* Made all checkbox checked whenall lessons are already completed

* Added tests for ModifyLessonProgressControllerTest

* Added tests to MarkChapters/Stories/TopicsCompletedTest

* Fixed failing tests

* Nit fixes

* Removed unnecessary boolean return

* Fixed lint issue

* Nit fix

* Nit fix

* Fixed MARK COMPLETED button alignment

* Code refactor and renamed tests

* Fixed finish activity test

* Fixed failing build and tests

* Added files to test_file_exemptions

* Removed unnecessary tests

* Nit fixes
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashraj-01 yashraj-01

Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3303, #3305 and #3306: Implement logic to modify lesson progress oppia/oppia-android
2 participants
@BenHenning @yashraj-01