Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a BUILD.bazel file for domain/testing/oppialogger/loguploader/ #3278

Closed
fsharpasharp opened this issue Jun 8, 2021 · 1 comment · Fixed by #3742
Closed

Create a BUILD.bazel file for domain/testing/oppialogger/loguploader/ #3278

fsharpasharp opened this issue Jun 8, 2021 · 1 comment · Fixed by #3742
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@fsharpasharp
Copy link
Contributor

This task is part of the build system migration from Gradle to Bazel.

Prerequesites

Task

  1. Create a BUILD.bazel file in

domain/src/main/java/org/oppia/android/domain/testing/oppialogger/loguploader

  1. Define the kt_android_library library/libraries

Based on the imports in the Kotlin files, add the required third_party dependencies to make the libraries build. Check the Useful links section for a list of third_party dependencies. You may also need to add the non third_party dependencies.

This package should depend on on a logging library from the util module.

  1. Add the directory to the MIGRATED_PROD_FILES of the module's root BUILD.bazel file

  2. Add the libraries to the list of deps dependencies in the targets that require the library

You will have to set the apropriate visbility. See the list of visibilities in the link below.

  1. Clean up any unused deps dependencies

  2. Verify that the app builds

Useful links

@jonathanalvares9009 jonathanalvares9009 self-assigned this Jul 2, 2021
@seanlip seanlip added this to To do (Stage 2) in Bazel Migration Aug 12, 2021
@yash10019coder
Copy link
Contributor

@jonathanalvares9009 are you working on this?

@jonathanalvares9009 jonathanalvares9009 removed their assignment Aug 24, 2021
@yash10019coder yash10019coder self-assigned this Aug 25, 2021
BenHenning pushed a commit that referenced this issue Oct 19, 2021
…ploader (#3742)

* added BUILD.bazel file

* Changed Descroption of the bazel file
Added dagger
And also chaged the src according to the comment

* Update BUILD.bazel

Added dagger_rules() in bazel

* corrected true in testonly bazel

* Update BUILD.bazel

* formatted bazel file

* Added src of kt file according to the old format

* removed earlier deps and used new util assets dep from the glob of bazel/domain

* removed the earlier testing library in domain/bazel

* updated the dependencies for the old testing library with new fake_log_uploader in domain/bazel

* added the test_resources target in domain/bazel to fix failing tests.

* reformatted domain/bazel

* Revert "reformatted domain/bazel"

This reverts commit d3c3edf.

* Revert "added the test_resources target in domain/bazel to fix failing tests."

This reverts commit 88fbfa0.

* added test_resources target in domain/bazel
added dependency for LogUploader in testing.oppialogger.loguploader/bazel
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Bazel Migration
  
To do (Stage 2)
4 participants