Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hi-Fi App Version Tablet #3240

Closed
anandwana001 opened this issue May 24, 2021 · 4 comments · Fixed by #3806
Closed

Hi-Fi App Version Tablet #3240

anandwana001 opened this issue May 24, 2021 · 4 comments · Fixed by #3806
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@anandwana001
Copy link
Contributor

anandwana001 commented May 24, 2021 •
edited by rt4914
Loading

Mobile - https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/79e0846d-de5c-42b7-93aa-f93d4995616d/

Tablet - https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/80d1f4d6-be84-42db-ab23-9b5e1eb6e596/

Follow this guide: https://github.com/oppia/oppia-android/wiki/Working-on-UI
@anandwana001 anandwana001 changed the title Hi-Fi App Version Hi-Fi App Version Tablet May 24, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 11, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta in CLAM Team (deprecated -- please use new board) Jul 11, 2021
@rt4914 rt4914 moved this from Beta (Features & Tasks) to High-fi Beta in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@Pranav-Bobde
Copy link
Contributor

Please assign me this issue.

@Pranav-Bobde
Copy link
Contributor

Just wanted to bring to notice that while while working on this issue #3240, I came across this bug. Seems like the view from the 'Edit Profile' is still there (JUST INVISIBLE) even after selecting something else.

Here is a clip of the same bug.

2021-08-17.22-22-55.mp4

@anandwana001
Copy link
Contributor Author

@Pranav-Bobde Could you please file an issue for this bug with all the necessary details, also is this happening in the latest develop branch?

@Pranav-Bobde
Copy link
Contributor

Pranav-Bobde commented Aug 20, 2021 •
edited
Loading

@anandwana001 Ok, can you help me in finding which fragment is that (containing list of profiles in Edit Profiles).
Yes, in the latest develop only i tried, the mobile one is fine, this only seems to be a problem in Tablets(MULTIPANE).

@Pranav-Bobde Pranav-Bobde mentioned this issue Aug 20, 2021
Closed
8 tasks
@Pranav-Bobde Pranav-Bobde mentioned this issue Sep 16, 2021
Merged
6 tasks
CLAM Team (deprecated -- please use new board) automation moved this from [Beta] Low-fi & High-fi to Closed Sep 24, 2021
rt4914 pushed a commit that referenced this issue Sep 24, 2021
@Pranav-Bobde
Fix #3240: Hi fi app versoin shadow fix (#3806)
baf7fd2 
* removed view and fragment layout from app_version_fragment

* added view in app_version_activity.xml

* final change

* made suggested changes

* made suggested changes
@Pranav-Bobde Pranav-Bobde removed their assignment Sep 28, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
3 participants
@BenHenning @anandwana001 @Pranav-Bobde