Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextInputLayout text cursor is not visible when the text is empty #3133

Closed
FareesHussain opened this issue Apr 28, 2021 · 7 comments · Fixed by #3638
Closed

TextInputLayout text cursor is not visible when the text is empty #3133

FareesHussain opened this issue Apr 28, 2021 · 7 comments · Fixed by #3638
Assignees
@rawlin
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@FareesHussain
Copy link
Contributor

Describe the bug
TextInputLayout in Create Pin, Add profile and other activities doesn't display cursor when there is no input

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Add Profile in Profile Selection Activity'
  2. Click on 'Administrator's Pin (TextInputLayout)'
  3. See that the cursor is not displayed.

Expected behavior
To show the cursor when the TextInputLayout is focused.

Video

textInputLayout.mp4
@AnubhavPabby
Copy link

@FareesHussain Can I work on this issue?

@rishidyno
Copy link
Contributor

rishidyno commented Jun 21, 2021 •
edited
Loading

@AnubhavPabby are you still working on this issue if not @FareesHussain please assign me this task. Also, I am a beginner so, please guide me through.

@rt4914 rt4914 assigned rishidyno and unassigned AnubhavPabby Jun 21, 2021
@rishidyno rishidyno removed their assignment Jul 3, 2021
@rawlin
Copy link
Contributor

rawlin commented Aug 1, 2021

@FareesHussain could you assign me this issue?

@rawlin
Copy link
Contributor

rawlin commented Aug 2, 2021

@rt4914 Could you assign this issue to me?

@yash10019coder
Copy link
Contributor

@rawlin Are you still working on this?

@rawlin
Copy link
Contributor

rawlin commented Aug 18, 2021

Yes, I am. Just a minor change left to merge to PR

@yash10019coder
Copy link
Contributor

Ok

@rawlin rawlin mentioned this issue Aug 18, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Aug 18, 2021
@rawlin
Fix #3133: TextInputLayout text cursor is not visible when the text i…
da652a4 
…s empty (#3638)

* Fix for cursor not showing when in focus in AdminPinActivity

* Added custom drawable for text cursor

* Added extra line at EOF in color_cursor.xml

* Made color_cursor a part of the EditText style
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawlin rawlin

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3133: TextInputLayout text cursor is not visible when the text is empty rawlin/oppia-android
6 participants
@BenHenning @AnubhavPabby @rawlin @FareesHussain @yash10019coder @rishidyno