Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tablet Drawer UI Difference #3108

Closed
anandwana001 opened this issue Apr 21, 2021 · 2 comments · Fixed by #3702
Closed

Tablet Drawer UI Difference #3108

anandwana001 opened this issue Apr 21, 2021 · 2 comments · Fixed by #3702
Assignees
@UttaranDas
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@anandwana001
Copy link
Contributor

anandwana001 commented Apr 21, 2021 •
edited by rt4914
Loading

Describe the bug
The width of Navigation drawer in tablet is different.

To Reproduce
Steps to reproduce the behavior:

  1. Open the app on a tablet
  2. Open navigation drawer while on Home Menu
  3. Click Help
  4. Open the navigation drawer and see the drawer width is different

Expected behavior
The width should be the same

Screenshots

Solution
In all xml files which are using NavigationDrawer use a fixed width of 304dp. Also define this as navigation_drawer_width in dimens value.

Mock References
https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/6138b324-a09c-42cd-9a23-98aec305aca4/
https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/3a43a3ce-597a-4e4b-b509-3eafd4249528/
https://xd.adobe.com/view/3dca36c2-5115-419c-b25e-0f10526b077c-6899/screen/479649d5-6aec-49f1-b4d0-f446bad0f2bb/specs/

Device

  • emulator being used
  • SDK version - Pixel C API 28
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 11, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta in CLAM Team (deprecated -- please use new board) Jul 11, 2021
@rt4914 rt4914 moved this from Beta (Features) to Beta (Bugs & Fixes) in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@rt4914 rt4914 moved this from Beta (Bugs & Fixes) to High-fi Beta in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@rt4914
Copy link
Contributor

rt4914 commented Aug 6, 2021

Assigning this to @UttaranDas considering a part of it is getting solved in #3597

@rt4914
Copy link
Contributor

rt4914 commented Aug 18, 2021

@UttaranDas Any updates?

UttaranDas added a commit to UttaranDas/oppia-android that referenced this issue Aug 18, 2021
@UttaranDas
Fix oppia#3108: Applied dimens value navigation_drawer_width to layou…
c55eefa 
…t_width
@UttaranDas UttaranDas mentioned this issue Aug 18, 2021
Merged
8 tasks
UttaranDas added a commit to UttaranDas/oppia-android that referenced this issue Aug 29, 2021
@UttaranDas
Fix oppia#3108: Applied dimens value navigation_drawer_width to layou…
40c20fa 
…t_width
CLAM Team (deprecated -- please use new board) automation moved this from [Beta] Low-fi & High-fi to Closed Aug 30, 2021
rt4914 pushed a commit that referenced this issue Aug 30, 2021
@UttaranDas
Fix #3108: Applied dimens value navigation_drawer_width to layout_wid…
9ed4862 
…th (#3702)

* Fix #3108: Applied dimens value navigation_drawer_width to layout_width

* Fix #3108: Applied dimens value navigation_drawer_width to layout_width
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UttaranDas UttaranDas

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3108: Applied dimens value navigation_drawer_width to layout_width UttaranDas/oppia-android
4 participants
@rt4914 @BenHenning @anandwana001 @UttaranDas