Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Admin Auth Screen #2616

Closed
2 tasks done
rt4914 opened this issue Feb 4, 2021 · 6 comments
Closed
2 tasks done

[A11y] Admin Auth Screen #2616

rt4914 opened this issue Feb 4, 2021 · 6 comments
Assignees
@Arjupta
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 4, 2021 •
edited
Loading

Current Output

current_admin_auth_full_video.mp4

Issues Identified

  • Inconsistency in output of Close button
    In case of Admin Add Pin screen the close button outputs "Navigate Up, Button" and in Admin Auth Pin screen the output is "Close, Button". Use "Close, Button" for both cases. (Assigned to @Sparsh1212)
  • Inactive submit button outputs "SUBMIT, Button" instead it should output "SUBMIT, Button, disabled" (Assigned to @Arjupta )

These issues are same for mobile-landscape, mobile-portrait, tablet-landscape and tablet-portrait.

Note: To understand the above issue(s) completely, it is recommended that you setup Talkback and play with the app keeping it on and that will give you better context.

Accessibility Guide: https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide
@rt4914 rt4914 added Status: Blocked Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Feb 4, 2021
@rt4914 rt4914 added this to the Beta milestone Feb 4, 2021
@mschanteltc
Copy link

  • Both texts should be separate. Heading and description serve different purposes, thus it would be better to have them to have their own output.
  • Use "Close, Button"

@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. and removed Status: Blocked labels Feb 5, 2021
@rt4914 rt4914 changed the title [A11y] Admin Auth Screen [Blocked on Discussion] [A11y] Admin Auth Screen Feb 5, 2021
@rt4914 rt4914 mentioned this issue Feb 5, 2021
Closed
3 tasks
@Sparsh1212
Copy link
Contributor

Sparsh1212 commented Feb 5, 2021 •
edited
Loading

@mschanteltc I would like to work on this issue. Please assign this to me if it is up for grab.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 5, 2021

@mschanteltc I would like to work on this issue. Please assign this to me if it is up for grab.

@Sparsh1212

Yes but suggest you checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

Once this is done. Comment again so that I can assign you this issue. Thanks.

@Sparsh1212
Copy link
Contributor

I have signed the CLA, filled the survey form, and have read the wiki too. Please assign this to me.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 5, 2021

@Sparsh1212 I have updated the description. I have assigned you only the first part of this issue. Second part will get done by Arjun in his current PRs.

@Sparsh1212 Sparsh1212 mentioned this issue Feb 6, 2021
Merged
8 tasks
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Feb 7, 2021
@Arjupta
Fixes part of oppia#2616: Admin Auth Screen[a11y]
7b44e1f 
Fixes the TalkBack response for disabled submit button by adding content
description
rt4914 pushed a commit that referenced this issue Feb 8, 2021
@Sparsh1212
Fix part of #2616: Admin auth screen (#2645)
ecf673d
@Arjupta Arjupta mentioned this issue Feb 8, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Feb 18, 2021
@Arjupta
Fixes part of #2616: Admin Auth Screen[a11y] (#2649)
d4a945f 
* Fixes part of #2616: Admin Auth Screen[a11y]

Fixes the TalkBack response for disabled submit button by adding content
description

* Reverted the changes

This reverts commit 7b44e1f.

* Recommended fix
@rt4914
Copy link
Contributor Author

rt4914 commented Feb 26, 2021

Closing this as both the issues have been solved in parts.

@rt4914 rt4914 closed this as completed Feb 26, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjupta Arjupta

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
[Task Force] Full accessibility support - Android
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rt4914 @BenHenning @mschanteltc @Sparsh1212 @Arjupta