Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Drag Drop Interactions Item [A11y] [BLOCKED] #2323

Closed
Arjupta opened this issue Dec 26, 2020 · 0 comments · Fixed by #3388
Closed

Changes in Drag Drop Interactions Item [A11y] [BLOCKED] #2323

Arjupta opened this issue Dec 26, 2020 · 0 comments · Fixed by #3388
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Dec 26, 2020

Describe the bug

Views inside drag_drop_interaction_items.xml are not fully compatible with some users from the Accessibility point of view.

Issue 1 - The contrast ratio of content text inside a single item does not match the standard one
Issue 2 - Multiple arrow icons and merge icons have the same content description
Issue 3 - The size of the clickable arrows, merge icons and ungroup icons are less than the standard size (48dp x 48dp)

To Reproduce
Steps to reproduce the behaviour:

  1. Start the Accessibility Scanner App on your device
  2. Open the Oppia Android App and start First Test Topic Exploration
  3. Scan the screenshots with the Accessibility Scanner
  4. You will see the tests that are not passed by that screen
  5. Repeat this for other screens

Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.

Screenshots

Issue 1 Issue 2 Issue 3
Screenshot_2020-12-17-11-16-47-01_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-17-11-16-39-07_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-17-11-16-34-29_80a9469f53bfe75dbc6e8989be28e2f0
Screenshot_2020-12-17-11-16-21-90_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-17-11-16-16-49_80a9469f53bfe75dbc6e8989be28e2f0
Screenshot_2020-12-17-11-19-25-56_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-17-11-19-19-21_80a9469f53bfe75dbc6e8989be28e2f0
Screenshot_2020-12-17-11-21-02-10_80a9469f53bfe75dbc6e8989be28e2f0

Device

  • Real Device - RealMe3
  • SDK version - 29

Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.

Certain Views does not have the correct contrast ratios (Inactive state) as mentioned in the screenshots. To solve this, one must find a way to make the views disabled instead of being in non-clickable state only

Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner

@Arjupta Arjupta added Status: Not started Priority: Essential This work item must be completed for its milestone. labels Dec 26, 2020
@Arjupta Arjupta added this to the Beta milestone Dec 26, 2020
@Arjupta Arjupta changed the title Changes in Drag Drop Interactions Item (Accessibility point of View) [BLOCKED] Changes in Drag Drop Interactions Item [A11y] [BLOCKED] Jan 2, 2021
@rt4914 rt4914 self-assigned this May 23, 2021
rt4914 added a commit that referenced this issue Jun 29, 2021
* External margins UI

* Internal non-recyclerview padding

* Full UI

* Full UI with accessibility

* Nit fix

* drag-and-drop-a11y-fix

* Nit fix

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

3 participants