-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in Drag Drop Interactions Item [A11y] [BLOCKED] #2323
Labels
Priority: Essential
This work item must be completed for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
This was referenced May 25, 2021
rt4914
added a commit
that referenced
this issue
Jun 29, 2021
* External margins UI * Internal non-recyclerview padding * Full UI * Full UI with accessibility * Nit fix * drag-and-drop-a11y-fix * Nit fix Co-authored-by: Rajat Talesra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Essential
This work item must be completed for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Describe the bug
Views inside drag_drop_interaction_items.xml are not fully compatible with some users from the Accessibility point of view.
Issue 1 - The contrast ratio of content text inside a single item does not match the standard one
Issue 2 - Multiple arrow icons and merge icons have the same content description
Issue 3 - The size of the clickable arrows, merge icons and ungroup icons are less than the standard size (48dp x 48dp)
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.
Screenshots
Device
Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.
Certain Views does not have the correct contrast ratios (Inactive state) as mentioned in the screenshots. To solve this, one must find a way to make the views disabled instead of being in non-clickable state only
Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner
The text was updated successfully, but these errors were encountered: