Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in Numeric Input Interaction Item [A11y] #2314

Closed
Arjupta opened this issue Dec 24, 2020 · 6 comments
Closed

Changes in Numeric Input Interaction Item [A11y] #2314

Arjupta opened this issue Dec 24, 2020 · 6 comments
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Dec 24, 2020 •
edited
Loading

Describe the bug

Numeric Input Interaction Item is not fully compatible with some users from the Accessibility point of view.

Issue 1 - There is an ambiguity in the case of the NumericInputInteractionView, it has a content description attribute which will be read by screen readers instead of the content inside the NumericInputInteractionView (Obsolete Issue)

Issue 2 - The Contrast Ratio of the view doesn't match the standard one. (assigned to @Arjupta)

To Reproduce
Steps to reproduce the behaviour:

  1. Start the Accessibility Scanner App on your device
  2. Open the Oppia Android App and start First Test Topic Exploration
  3. Scan the screenshots with the Accessibility Scanner
  4. You will see the tests that are not passed by that screen
  5. Repeat this for other screens

Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.

Screenshots

Issue 1 Issue 2
Screenshot_2020-12-17-11-10-51-41_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-17-11-11-29-08_80a9469f53bfe75dbc6e8989be28e2f0
Screenshot_2020-12-17-11-11-05-96_80a9469f53bfe75dbc6e8989be28e2f0

Device

  • Real Device - RealMe3
  • SDK version - 29

Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.

Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner
@Arjupta Arjupta added Status: Not started Priority: Essential This work item must be completed for its milestone. labels Dec 24, 2020
@Arjupta Arjupta added this to the Beta milestone Dec 24, 2020
@Arjupta Arjupta changed the title Changes in Numeric Input Interaction Item (Accessibility point of View) [BLOCKED]] Changes in Numeric Input Interaction Item (Accessibility point of View) [BLOCKED] Dec 24, 2020
@Arjupta Arjupta changed the title Changes in Numeric Input Interaction Item (Accessibility point of View) [BLOCKED] Changes in Numeric Input Interaction Item [A11y] [BLOCKED] Jan 2, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jan 20, 2021

I tested this in A11y scanner but I was not able to find issue related to contrast. Can you please check this again and confirm.

@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 20, 2021

I tested this in A11y scanner but I was not able to find issue related to contrast. Can you please check this again and confirm.

I am able to reproduce this error here and was able to solve it too by the our discussion over Chantel's suggestion. Will be creating a PR if you are also able to reproduce it

@rt4914
Copy link
Contributor

rt4914 commented Jan 21, 2021

@Arjupta This is based on different device. Considering that you have mentioned the device I will have to try to reproduce on some other device. Lets keep this solution open for now but and also we don't have a solution yet for this.

@Arjupta Arjupta mentioned this issue Jan 23, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Jan 29, 2021
@Arjupta
Fixes part of #2314: Changes in Numeric Input Interaction Item[a11y] (#…
9fd6d7a 
…2548)

* Tried setting 1dp stroke instead of blue shadow

* Removing the bottom padding for correct orientation

* Suggested changes on background drawable

* EOF was missing
@Arjupta Arjupta assigned mschanteltc and unassigned mschanteltc Feb 15, 2021
@Arjupta
Copy link
Contributor Author

Arjupta commented Feb 15, 2021

@rt4914 we can close this issue too as the label are going to be presented in the prod app

@rt4914 rt4914 closed this as completed Feb 15, 2021
@rt4914 rt4914 reopened this Feb 15, 2021
@rt4914
Copy link
Contributor

rt4914 commented Feb 15, 2021

@Arjupta please update the description and then we can close. Also remove BLOCKED from title

@Arjupta Arjupta changed the title Changes in Numeric Input Interaction Item [A11y] [BLOCKED] Changes in Numeric Input Interaction Item [A11y] Feb 15, 2021
@Arjupta
Copy link
Contributor Author

Arjupta commented Feb 15, 2021

@Arjupta please update the description and then we can close. Also remove BLOCKED from title

@rt4914 Done

@rt4914 rt4914 closed this as completed Feb 15, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
[Task Force] Full accessibility support - Android
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rt4914 @BenHenning @mschanteltc @Arjupta