-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in Profile List View [A11y] [BLOCKED] #2217
Labels
Priority: Essential
This work item must be completed for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
Arjupta
added
Status: Not started
good first issue
This item is good for new contributors to make their pull request.
Priority: Essential
This work item must be completed for its milestone.
labels
Dec 3, 2020
Arjupta
removed
the
good first issue
This item is good for new contributors to make their pull request.
label
Dec 7, 2020
@mschanteltc can you give some description on how to resolve this |
Let's change the subtext to #555555. LMK what contrast ratio that would make it and if it is sufficient enough. |
Arjupta
changed the title
Changes in Profile List View (Accessibility point of view) [BLOCKED]
Changes in Profile List View (Accessibility point of view)
Dec 14, 2020
Arjupta
changed the title
Changes in Profile List View (Accessibility point of view)
Changes in Profile List View [A11y]
Jan 2, 2021
Arjupta
changed the title
Changes in Profile List View [A11y]
Changes in Profile List View [A11y] [BLOCKED]
Jan 2, 2021
Arjupta
added a commit
to Arjupta/oppia-android
that referenced
this issue
Jan 11, 2021
Fixes Issue 1 of oppia#2217, Changed TextColor as per Chantel's suggesstion
8 tasks
Checklist(Contributors can take one issue at a time)
|
Reopening it as it got closed automatically by merging a PR which solved only a part of this Issue |
8 tasks
rt4914
added a commit
that referenced
this issue
Feb 23, 2021
* Profile Edit A11y fixes * Nit fix * Nit fix Co-authored-by: Rajat Talesra <[email protected]>
BenHenning
added
the
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
label
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Essential
This work item must be completed for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Describe the bug(Considering only admin profile)
The Profile List Fragment under Edit profiles option of Administrator Controls have certain views which are not fully compatible from the Accessibility point of view.
Issue 1 - The Contrast ratio (foreground to background) of text inside profile_list_profie_view is 2.68 but the suggested one is 4.50 (under profile_list_fragment)
Issue 2 - Multiple items have the same Description as that of textview inside the toolbar present in the profile_edit_activity
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.
Screenshots
Device
Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.
Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner
The text was updated successfully, but these errors were encountered: