Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Profile List View [A11y] [BLOCKED] #2217

Closed
Arjupta opened this issue Dec 3, 2020 · 4 comments · Fixed by #2739
Closed

Changes in Profile List View [A11y] [BLOCKED] #2217

Arjupta opened this issue Dec 3, 2020 · 4 comments · Fixed by #2739
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Dec 3, 2020

Describe the bug(Considering only admin profile)

The Profile List Fragment under Edit profiles option of Administrator Controls have certain views which are not fully compatible from the Accessibility point of view.

Issue 1 - The Contrast ratio (foreground to background) of text inside profile_list_profie_view is 2.68 but the suggested one is 4.50 (under profile_list_fragment)
Issue 2 - Multiple items have the same Description as that of textview inside the toolbar present in the profile_edit_activity

To Reproduce
Steps to reproduce the behaviour:

  1. Start the Accessibility Scanner App on your device
  2. Open the Oppia Android App and scan the screenshots with the Accessibility Scanner
  3. You will see the tests that are not passed by that screen
  4. Repeat this for other screens

Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.

Screenshots

Issue 1 Issue 2
Screenshot_2020-12-03-15-36-55-72_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-03-15-37-17-27_80a9469f53bfe75dbc6e8989be28e2f0

Device

  • Real Device - RealMe3
  • SDK version - 29

Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.

Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner

@Arjupta Arjupta added Status: Not started good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. labels Dec 3, 2020
@Arjupta Arjupta added this to the Beta milestone Dec 3, 2020
@Arjupta Arjupta removed the good first issue This item is good for new contributors to make their pull request. label Dec 7, 2020
@Arjupta
Copy link
Contributor Author

Arjupta commented Dec 7, 2020

@mschanteltc can you give some description on how to resolve this

@mschanteltc
Copy link

@mschanteltc can you give some description on how to resolve this

Let's change the subtext to #555555. LMK what contrast ratio that would make it and if it is sufficient enough.

@Arjupta Arjupta changed the title Changes in Profile List View (Accessibility point of view) [BLOCKED] Changes in Profile List View (Accessibility point of view) Dec 14, 2020
@Arjupta Arjupta changed the title Changes in Profile List View (Accessibility point of view) Changes in Profile List View [A11y] Jan 2, 2021
@Arjupta Arjupta changed the title Changes in Profile List View [A11y] Changes in Profile List View [A11y] [BLOCKED] Jan 2, 2021
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Jan 11, 2021
Fixes Issue 1 of oppia#2217, Changed TextColor as per Chantel's suggesstion
@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 21, 2021

Checklist

(Contributors can take one issue at a time)

  • Issue-1 (assigned to @Arjupta)
  • Issue-2 (not assigned to anyone)

@rt4914 rt4914 closed this as completed in f0edf63 Jan 25, 2021
@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 26, 2021

Reopening it as it got closed automatically by merging a PR which solved only a part of this Issue

@Arjupta Arjupta reopened this Jan 26, 2021
@rt4914 rt4914 self-assigned this Feb 17, 2021
rt4914 added a commit that referenced this issue Feb 23, 2021
* Profile Edit A11y fixes

* Nit fix

* Nit fix

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

4 participants