Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Changes in Admin Controls Download Permissions View #2210

Closed
Arjupta opened this issue Dec 2, 2020 · 9 comments
Closed

[A11y] Changes in Admin Controls Download Permissions View #2210

Arjupta opened this issue Dec 2, 2020 · 9 comments
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Dec 2, 2020

Describe the bug

Admin Control Download Permission View is not fully compatible with some users from the Accessibility point of view.
Screenshot_2020-12-02-11-13-39-64_80a9469f53bfe75dbc6e8989be28e2f0
Issue 1 - The Size of Switch button must be larger ( minimum 48dpX48dp)
Issue 2 - Multiple items have the same Description as that of Switch Button
Issue 3 - The Contrast ratio of the text (foreground and background) inside the TextViews is 2.68 but the required one 4.50

To Reproduce
Steps to reproduce the behaviour:

  1. Start the Accessibility Scanner App on your device
  2. Open the Oppia Android App and scan the screenshots with the Accessibility Scanner
  3. You will see the tests that are not passed by that screen
  4. Repeat this for other screens

Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.

Screenshots

Issue 1 Issue 2 Issue 3
Screenshot_2020-12-02-11-13-18-10_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-02-11-13-28-16_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-02-11-13-04-76_80a9469f53bfe75dbc6e8989be28e2f0

Device

  • Real Device - RealMe3
  • SDK version - 29

Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.

Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner

@Arjupta Arjupta added this to the Beta milestone Dec 2, 2020
@Arjupta Arjupta added good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. and removed good first issue This item is good for new contributors to make their pull request. labels Dec 2, 2020
@7phalange7
Copy link
Contributor

Hello @Arjupta , I'm working on the issue. Please assign me the issue.

@Arjupta
Copy link
Contributor Author

Arjupta commented Dec 8, 2020

@7phalange7 assigned it to you

@7phalange7
Copy link
Contributor

@Arjupta to fix the above issues I need to add min height/weight and text color, So should I use hardcoded values or make new entries in @dimens and @color resources and use them?

@Arjupta
Copy link
Contributor Author

Arjupta commented Dec 8, 2020

@Arjupta to fix the above issues I need to add min height/weight and text color, So should I use hardcoded values or make new entries in @dimens and @color resources and use them?

You must use dimens and color files for resolving any issue.

@Arjupta Arjupta changed the title Changes in Admin Controls Download Permissions View (Accessibility point of view) [BLOCKED] Changes in Admin Controls Download Permissions View (Accessibility point of view) Dec 14, 2020
@Arjupta Arjupta changed the title Changes in Admin Controls Download Permissions View (Accessibility point of view) Changes in Admin Controls Download Permissions View [A11y] Jan 2, 2021
@rt4914 rt4914 changed the title Changes in Admin Controls Download Permissions View [A11y] [A11y] Changes in Admin Controls Download Permissions View [BLOCKED] Jan 5, 2021
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Jan 11, 2021
Fixes Issue 3 of oppia#2210,
Changed the text color as per Chantel's suggesstion
@Arjupta Arjupta changed the title [A11y] Changes in Admin Controls Download Permissions View [BLOCKED] [A11y] Changes in Admin Controls Download Permissions View Jan 21, 2021
@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 21, 2021

Checklist

(Contributors can take one issue at a time)

  • Issue-1 (assigned to @7phalange7 )
  • Issue-2 (not assigned to anyone)
  • Issue-3 (assigned to @Arjupta )

@7phalange7
Copy link
Contributor

@Arjupta please assign me Issue-2 (or Issue-1 any one is fine) . Just to confirm, is this issue ready to be worked upon?

@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 22, 2021

@Arjupta please assign me Issue-2 (or Issue-1 any one is fine) . Just to confirm, is this issue ready to be worked upon?

Issue -1 is ready to be worked upon. Assigned it to you. Try attaching a screenshot of before changes , after changes and test scans also in your Pull Request

@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 26, 2021

Reopening it as it got closed automatically by merging a PR which solved only a part of this Issue

@Arjupta Arjupta reopened this Jan 26, 2021
@rt4914
Copy link
Contributor

rt4914 commented May 23, 2021

Closing as it will get solved in #2618

@rt4914 rt4914 closed this as completed May 23, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
4 participants