Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in Admin Pin Activity [A11y] #2206

Closed
Arjupta opened this issue Dec 2, 2020 · 6 comments · Fixed by #2626
Closed

Changes in Admin Pin Activity [A11y] #2206

Arjupta opened this issue Dec 2, 2020 · 6 comments · Fixed by #2626
Assignees
@Arjupta
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Dec 2, 2020

Describe the bug

Admin Pin Activity Screens are not fully compatible with some users from the Accessibility point of view.
Issue 1 - No Item Label present in both the profile input view when no data are typed in it ie. in the inactive state
Issue 2 - Multiple items have the same Description as that of Profile Input View when some data is entered in it ie. active state
Issue 3 - The Contrast ratio of the text (foreground and background) inside the Submit button is 2.58 (in inactive state) but the required one 4.50

To Reproduce
Steps to reproduce the behaviour:

  1. Start the Accessibility Scanner App on your device
  2. Open the Oppia Android App and scan the screenshots with the Accessibility Scanner
  3. You will see the tests that are not passed by that screen
  4. Repeat this for other screens

Expected behaviour
All the tests must be passed by scanning the screenshots for both Tablet and Mobile Devices in every orientation.

Screenshots

Issue 1 Issue 2 Issue 3
Screenshot_2020-12-02-10-49-03-67_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-02-10-52-27-12_80a9469f53bfe75dbc6e8989be28e2f0 Screenshot_2020-12-02-10-49-41-05_80a9469f53bfe75dbc6e8989be28e2f0

Device

  • Real Device - RealMe3
  • SDK version - 29

Additional context
The Screenshots are descriptive enough for understanding the issues but still, if there is a need of clarification then you can comment here. Multiple Pull Requests can also be made for solving these issues.

Reference - https://github.com/oppia/oppia-android/wiki/Working-on-UI#accessibility-scanner
@Arjupta Arjupta added this to the Beta milestone Dec 2, 2020
@Arjupta Arjupta added Priority: Essential This work item must be completed for its milestone. good first issue This item is good for new contributors to make their pull request. and removed good first issue This item is good for new contributors to make their pull request. labels Dec 2, 2020
@Arjupta
Copy link
Contributor Author

Arjupta commented Dec 11, 2020

Currently, views are marked as non-clickable in the inactive state which causes the contrast issue, they should be marked enabled/disabled based on their state which will prevent the scanner to detect it as an error

@Arjupta Arjupta changed the title Changes in Admin Pin Activity (Accessibility point of view) [BLOCKED] Changes in Admin Pin Activity (Accessibility point of view) Dec 14, 2020
@Arjupta Arjupta changed the title Changes in Admin Pin Activity (Accessibility point of view) Changes in Admin Pin Activity [A11y] Jan 2, 2021
@Arjupta Arjupta changed the title Changes in Admin Pin Activity [A11y] Changes in Admin Pin Activity [A11y] [BLOCKED] Jan 2, 2021
@Arjupta Arjupta changed the title Changes in Admin Pin Activity [A11y] [BLOCKED] Changes in Admin Pin Activity [A11y] Jan 21, 2021
@Arjupta
Copy link
Contributor Author

Arjupta commented Jan 21, 2021 •
edited
Loading

Checklist

(Contributors can take one issue at a time)

  • Issue-1 (not assigned to anyone)
  • Issue-2 (assigned to @Arjupta )
  • Issue-3 (assigned to @Arjupta )

@Mehul-Bisht
Copy link
Contributor

Mehul-Bisht commented Jan 31, 2021 •
edited
Loading

@Arjupta it seems that all the EditTexts have been replaced with TextInputEditTexts now so now the only issue should be with the contrast ratios I believe?

@Arjupta
Copy link
Contributor Author

Arjupta commented Feb 2, 2021

@Arjupta it seems that all the EditTexts have been replaced with TextInputEditTexts now so now the only issue should be with the contrast ratios I believe?

Will test and discuss about this with team

@rt4914
Copy link
Contributor

rt4914 commented Feb 4, 2021

@mschanteltc
The below image shows the contrast color error for border of the editexts. What should be the border color to fix this?

@mschanteltc
Copy link

Let's make the border #666666.

@Arjupta Arjupta assigned Arjupta and unassigned mschanteltc Feb 5, 2021
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Feb 5, 2021
@Arjupta
Fix oppia#2206: Changes in Admin Pin Activity[a11y]
82386c6 
Fixes oppia#2206 by using different stroke color for TextInputLayout and
setting the buttons to be disabled when inactive
@Arjupta Arjupta mentioned this issue Feb 5, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Feb 5, 2021
@Arjupta
Fix #2206: Changes in Admin Pin Activity[a11y] (#2626)
e8fd3a3 
Fixes #2206 by using different stroke color for TextInputLayout and
setting the buttons to be disabled when inactive
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjupta Arjupta

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
[Task Force] Full accessibility support - Android
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2206: Changes in Admin Pin Activity[a11y] Arjupta/oppia-android
5 participants
@rt4914 @BenHenning @mschanteltc @Arjupta @Mehul-Bisht