Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full UI: NavigationDrawerFragment #22

Closed
BenHenning opened this issue Aug 2, 2019 · 3 comments
Closed

Full UI: NavigationDrawerFragment #22

BenHenning opened this issue Aug 2, 2019 · 3 comments
Assignees
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Sponsor Member

The navigation drawer should provide navigation options to the home screen, profile selection page (by logging out), settings page, and admin settings page (if the logged in user is an admin). See the PRD for specifics.

@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Sponsor Member Author

This is blocked on #10 to provide an initial page to navigate to. If it is implemented before other pages are available, it will be extended to include routes to those pages once they are available.

This should be designed in an extensible way to trivially allow for new pages to be added.

@BenHenning
Copy link
Sponsor Member Author

This is blocked on #43.

@BenHenning BenHenning changed the title Navigation drawer Navigation drawer [Blocked: #10, #43] Aug 12, 2019
@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. and removed Priority: Essential This work item must be completed for its milestone. labels Sep 9, 2019
@BenHenning BenHenning changed the title Navigation drawer [Blocked: #10, #43] Full UI: NavigationDrawerFragment Sep 20, 2019
@BenHenning
Copy link
Sponsor Member Author

NB: This actually isn't blocking. This issue is tracking the initial implementation of the navigation drawer for HomeActivity, where it can be extended later on to include other activities as needed.

nikitamarysolomanpvt added a commit that referenced this issue Nov 28, 2019
* xml files of navigation drawer

* dimentions updated in xml file and removed from dimens file

* removed help_activity.xml due to dependency and other nit changes

* removed dimention of navigation drawer layout height in dimens
jamesxu0 added a commit that referenced this issue Dec 14, 2019
…22, #48] (#542)

* implemented get and delete

* Finished test cases

* added observing cachestore

* Fixed test cases

* Finished first draft of implementation

* Added additional checks to setCurrentProfileId

* Added more test cases

* Finished test stubs

* Finished test cases

* Added query string to gravatar

* primed cache on init

* Fixed typo

* Fixed addProfile test case

* added create method to PersistentCacheStore

* added setTimestamp and setAdmin

* changed isAdmin to default to false

* Added update last logged in

* Started working on chooser

* debugging

* Added UI for chooser

* added click functionality

* Minor fixes

* Started basic admin auth and add profile

* Updated to use deferred value from persistentCacheStore

* Updated to use login

* Ensured result is error to post error value

* name can only be letters and unique check now case insensitive

* Added profile sorting by last accessed

* Fixed margins and added gradient

* allow names to have spaces

* Switched fragments to activities

* Finished admin auth styling

* Styled inputs for add profile

* Fixed name only letters toast

* Added support for upload image

* Started custom view

* added upload image and fixed input styling

* Added image rotation and compression

* Added red color

* fixed api requires for exifinterface

* Changed gradle dependency

* Added error handling ui support

* Added new asset and changed colors

* hide keyboard on create

* changed selectedImage to private

* Moved bindingadapter to companion object

* Started activity

* removed fragment checks

* Finished basic flow of pin password

* Added show password button

* Added input to dialog

* Sorted alphabetically

* added local default to tolowercase

* updated comment

* Renamed keys

* Updated key

* Changed to getProfile from database

* Added change pin dialogs

* Added pin input animation and go to play store

* added info icon

* started profile test helper

* Removed broken test, couldn't get mockito to work

* Added ProfileTestHelperTest

* added test case for profilechooserfragment

* Added test for AdminAuthActivity

* using string.xml values in tests

* Started AddProfileActivityTest

* Finished test cases

* Finished test cases and adjusted sizes

* Minor fixes and added default profile avatar

* minor fixes

* added endline

* Minor fixes

* removed resources

* Minor fixes

* Minor fixes.

* Started updating to DataProviders

* Fixed recyclerview

* Fixed loginToProfile

* Minor fixes

* Added comments and new test.

* minor fixes

* Fixed bug

* Added vector version of avatar

* Minor fixes.

* Converted livedata to dataproviders

* Minor fixes

* Removed coroutines from test.

* Added helper methods

* Removed ExperimentalCoroutinesApi

* Removed import

* Removed ExperimentalCouroutinesApi

* Addressed comments

* Fixed Project.xml

* Addressed all comments.

* Fixed failing test cases

* Updated xml to multiples of 4

* Fixed dp values

* Minor fixes

* Fixed dp

* Fixed ProfileTestHelper

* Added avatar color support.

* Added Ben's createTimer

* Addressed comments in previous PRs that didn't get pushed before.

* Removed lines

* Added admin pin creation flow

* Fixed tests

* Merge branch 'profile-avatar-colors' into profile-admin-flow

* Added back button dialog to home activity

* Initial changes, fragments to activities

* Added basic recyclerview

* Added recyclerview databinding

* added new line

* Updated log statement

* Updated domain test case

* Added AdminPinTests

* Removed unused imports

* Finished test cases

* Cleaner profile avatar design

* Updated profile:src

* Removed textUtils

* Reverted splash activity

* Removed unused imports

* Updated to now store colorHex and other fixes.

* Updated comment.

* Updated to colorRgb

* Added fixes

* Updated to force admin.

* Updated comments.

* Nit fixes.
jamesxu0 added a commit that referenced this issue Dec 14, 2019
…ty, and ProfileResetPinActivity in settings [Blocked #22, #48] (#543)

* implemented get and delete

* Finished test cases

* added observing cachestore

* Fixed test cases

* Finished first draft of implementation

* Added additional checks to setCurrentProfileId

* Added more test cases

* Finished test stubs

* Finished test cases

* Added query string to gravatar

* primed cache on init

* Fixed typo

* Fixed addProfile test case

* added create method to PersistentCacheStore

* added setTimestamp and setAdmin

* changed isAdmin to default to false

* Added update last logged in

* Started working on chooser

* debugging

* Added UI for chooser

* added click functionality

* Minor fixes

* Started basic admin auth and add profile

* Updated to use deferred value from persistentCacheStore

* Updated to use login

* Ensured result is error to post error value

* name can only be letters and unique check now case insensitive

* Added profile sorting by last accessed

* Fixed margins and added gradient

* allow names to have spaces

* Switched fragments to activities

* Finished admin auth styling

* Styled inputs for add profile

* Fixed name only letters toast

* Added support for upload image

* Started custom view

* added upload image and fixed input styling

* Added image rotation and compression

* Added red color

* fixed api requires for exifinterface

* Changed gradle dependency

* Added error handling ui support

* Added new asset and changed colors

* hide keyboard on create

* changed selectedImage to private

* Moved bindingadapter to companion object

* Started activity

* removed fragment checks

* Finished basic flow of pin password

* Added show password button

* Added input to dialog

* Sorted alphabetically

* added local default to tolowercase

* updated comment

* Renamed keys

* Updated key

* Changed to getProfile from database

* Added change pin dialogs

* Added pin input animation and go to play store

* added info icon

* started profile test helper

* Removed broken test, couldn't get mockito to work

* Added ProfileTestHelperTest

* added test case for profilechooserfragment

* Added test for AdminAuthActivity

* using string.xml values in tests

* Started AddProfileActivityTest

* Finished test cases

* Finished test cases and adjusted sizes

* Minor fixes and added default profile avatar

* minor fixes

* added endline

* Minor fixes

* removed resources

* Minor fixes

* Minor fixes.

* Started updating to DataProviders

* Fixed recyclerview

* Fixed loginToProfile

* Minor fixes

* Added comments and new test.

* minor fixes

* Fixed bug

* Added vector version of avatar

* Minor fixes.

* Converted livedata to dataproviders

* Minor fixes

* Removed coroutines from test.

* Added helper methods

* Removed ExperimentalCoroutinesApi

* Removed import

* Removed ExperimentalCouroutinesApi

* Addressed comments

* Fixed Project.xml

* Addressed all comments.

* Fixed failing test cases

* Updated xml to multiples of 4

* Fixed dp values

* Minor fixes

* Fixed dp

* Fixed ProfileTestHelper

* Added avatar color support.

* Added Ben's createTimer

* Addressed comments in previous PRs that didn't get pushed before.

* Removed lines

* Added admin pin creation flow

* Fixed tests

* Merge branch 'profile-avatar-colors' into profile-admin-flow

* Added back button dialog to home activity

* Initial changes, fragments to activities

* Added basic recyclerview

* Added recyclerview databinding

* added new line

* Initial profile read

* Updated log statement

* Added edit UI

* Finished profile updating

* Updated domain test case

* Added AdminPinTests

* Removed unused imports

* Finished test cases

* Finished rest of tests

* Removed imports

* Updated ResetPinActivity to include isAdmin

* Cleaner profile avatar design

* Updated profile:src

* Removed textUtils

* Updated profile edit avatar src

* Reverted splash activity

* Removed unused imports

* Updated to now store colorHex and other fixes.

* Updated comment.

* Updated to colorRgb

* Added fixes

* Updated to force admin.

* Updated comments.

* Nit fixes.

* Nit fixes.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

2 participants