Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter List Page Issues #2132

Closed
mschanteltc opened this issue Nov 20, 2020 · 9 comments · Fixed by #2422
Closed

Chapter List Page Issues #2132

mschanteltc opened this issue Nov 20, 2020 · 9 comments · Fixed by #2422
Assignees
@viktoriias
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@mschanteltc
Copy link

mschanteltc commented Nov 20, 2020 •
edited
Loading

  • There is no outline of inactive Chapter cards. Make sure there is still a shadow to each card. Do not decrease its opacity.
  • The description gets cut off after the fourth line. Since the Chapter description is not available elsewhere, make sure the full description is visible.
  • Update the inactive Chapter cards to blur thumbnails and hide descriptions (mock)

Screenshot_20201120-004517_Oppia
Screenshot_20201120-004508_Oppia
@viktoriias
Copy link
Contributor

I would like to work on this.

@anandwana001
Copy link
Contributor

@mschanteltc Regarding the second and the third point we only need description in the active card and for the inactive card, the description should not be visible, right?

The tasks we need to do on this issue:

  1. We need elevation to the inactive cards
  2. Full description should be visible
  3. Inactive card should not have a description

@viktoriias
Copy link
Contributor

Ok, I found "Matthew Goes to Bakery" screen. Do I need to blur thumbnails, like shown in the mock?

@mschanteltc
Copy link
Author

The tasks that need to be done are:

  • Elevate the inactive cards
  • Full description of active cards should show full description.
  • Inactive cards should be at full opacity
  • Inactive cards should show Chapter name and description should show prerequisites to unlock it.
  • Blur thumbnails of inactive cards

@viktoriias
Copy link
Contributor

I imagine I'd need a new image to blur inactive cards?

@viktoriias viktoriias mentioned this issue Dec 7, 2020
Merged
8 tasks
@mschanteltc
Copy link
Author

I imagine I'd need a new image to blur inactive cards?

For inactive cards, you would need the lock icon and to blur out the card's thumbnail image. Blur it by overlaying a container that is the exact color of the thumbnail's background, drop the opacity to 50%, and apply a blur.

anandwana001 pushed a commit that referenced this issue Dec 17, 2020
@viktoriias
Fix part of #2132: Chapter List Page Issues (#2232)
f80a8c2 
* Fix part of #2132

* Fix part of #2132

* Fix part of #2132

* Fix part of #2132

* Fix part of #2132

* Fix part of #2132

* Fix part of #2132

* Pass a ChapterSummary object as a prerequisite to unlock this chapter.
Remove blurring thumbnails of inactive cards - this change will be done separately.

* Added tests.

* Added tests.

* Set missingPrerequisiteChapter in setFirstChapterAsNotStarted function.

* Add a UI-facing test.

* Add more test coverage for a completed chapter.

* Move landscape test below the portrait one.

* Added long summary test + reformatting.

* Formatting.

* Lint

* Renaming
@viktoriias
Copy link
Contributor

I will be working on a second part of this issue - blurring and locking the image.

@viktoriias
Copy link
Contributor

viktoriias commented Dec 19, 2020 •
edited
Loading

I imagine I'd need a new image to blur inactive cards?

For inactive cards, you would need the lock icon and to blur out the card's thumbnail image. Blur it by overlaying a container that is the exact color of the thumbnail's background, drop the opacity to 50%, and apply a blur.

@mschanteltc What if background is white? Wouldn't it make the lock less visible?

@rt4914
Copy link
Contributor

rt4914 commented Dec 21, 2020

I imagine I'd need a new image to blur inactive cards?

For inactive cards, you would need the lock icon and to blur out the card's thumbnail image. Blur it by overlaying a container that is the exact color of the thumbnail's background, drop the opacity to 50%, and apply a blur.

@mschanteltc What if background is white? Wouldn't it make the lock less visible?

@viktoriias Background won't be white in production app. It will contain an image always.

@anandwana001 anandwana001 mentioned this issue Dec 22, 2020
Closed
1 task
@viktoriias viktoriias mentioned this issue Dec 22, 2020
Closed
8 tasks
@viktoriias viktoriias mentioned this issue Jan 7, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Feb 3, 2021
@viktoriias @BenHenning
Fix #2132: Chapter List Page Issues (#2232) - Blur and lock thumbnail…
2bcd511 
…s of inactive cards. (#2422)

* Lock and blur

* Replace color/white with #FFFFFF

* Add \n

* Move isBlurred to LessonThumbnailImageView.

* Remove unused import.

* Move dependency on Glide away from from ImageLoader.

* Remove unneeded line.

* Refactor Transformation-related code, add KDocs.

* Renaming.

* Remove unused import.

* Reformat.

* Add Mockk test

* Add Mockk test - lint

* Add blurring tests.

* Mock ImageLoader in StoryActivityTest.

* Add delay before image loading.

* Nits and improvements.

* Remove unused import.

* Remove unused import.

* Set image resources in LessonThumbnailImageView in addition to calling GlideImageLoader.

* BlurTransformation re-write.

* BlurTransformation re-write.

* Add TestImageLoaderModule to some tests.

* Lint

* Add TestImageLoaderModule to more tests.

* Add TestImageLoaderModule to more tests.

* Update utility/src/main/java/org/oppia/android/util/parser/BlurTransformation.kt

Co-authored-by: Ben Henning <[email protected]>

* Update utility/src/main/java/org/oppia/android/util/parser/BlurTransformation.kt

Co-authored-by: Ben Henning <[email protected]>

* TestGlideImageLoader Refactor.

* Reformat.

* Reformat.

* Reformat.

* Nits and comments.

* Revert changes in landscape design.

* Change BlurTransformation to return a copy instead of 'toTransform'.

* Update app/src/sharedTest/java/org/oppia/android/app/story/StoryFragmentTest.kt

Co-authored-by: Ben Henning <[email protected]>

* Refactor TestGlideImageLoader.

* Nits

Co-authored-by: Ben Henning <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktoriias viktoriias

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2132: Chapter List Page Issues (#2232) - Blur and lock thumbnails of inactive cards.
5 participants
@rt4914 @viktoriias @BenHenning @mschanteltc @anandwana001