Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile-Landscape] High-fi StoryActivity Updated UI #2093

Closed
2 tasks
rt4914 opened this issue Nov 6, 2020 · 29 comments · Fixed by #3802
Closed
2 tasks

[Mobile-Landscape] High-fi StoryActivity Updated UI #2093

rt4914 opened this issue Nov 6, 2020 · 29 comments · Fixed by #3802
Assignees
@viktoriias
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
CLAM Team (deprecated -- please use n...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Nov 6, 2020 •
edited
Loading

The StoryActivity UI has been updated a lot which is available here. https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/cce938d6-e079-4761-bac0-8bde22ac6348/

Major changes:

  • The inactive card content formation is updated.
  • RTL Supportive

Note : Please test UI for RTL support, prior to merging this fix.

Follow this guide: https://github.com/oppia/oppia-android/wiki/Working-on-UI
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. SLoP 2020 labels Nov 6, 2020
@rt4914 rt4914 added this to the Beta milestone Nov 6, 2020
@Aditiwebd
Copy link
Contributor

Please assign this to me @Sarthak2601

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 25, 2020

Un-assigning Aditi as there is no update.

@rt4914 rt4914 changed the title [Mobile-Landscape] High-fi StoryActivity Updated UI with lock and blur effect [Mobile-Landscape] High-fi StoryActivity Updated UI Nov 25, 2020
@ReCodee
Copy link

ReCodee commented Nov 25, 2020

@rt4914 Hello, I'm new to oppia and I'd love to work on this issue. Please assign this to me :)

ReCodee added a commit to ReCodee/oppia-android that referenced this issue Dec 1, 2020
@ReCodee
Fix oppia#2093: [Mobile-Landscape] High-fi StoryActivity Updated UI
9e16c2e
@ReCodee ReCodee mentioned this issue Dec 1, 2020
Closed
8 tasks
ReCodee added a commit to ReCodee/oppia-android that referenced this issue Dec 2, 2020
@ReCodee
Fix oppia#2093: [Mobile-Landscape] High-fi StoryActivity Updated UI
5042710
ReCodee added a commit to ReCodee/oppia-android that referenced this issue Dec 2, 2020
@ReCodee
Fix oppia#2093: [Mobile-Landscape] High-fi StoryActivity Updated UI
3def9d8
ReCodee added a commit to ReCodee/oppia-android that referenced this issue Dec 2, 2020
@ReCodee
Fix oppia#2093: [Mobile-Landscape] High-fi StoryActivity Updated UI
462709c
@anandwana001
Copy link
Contributor

@ReCodee As you had closed the PR, unassigning you.

@anshbajpai
Copy link

@rt4914 can you please assign this to me?

anshbajpai pushed a commit to anshbajpai/oppia-android that referenced this issue Feb 11, 2021
Fix oppia#2093: [Mobile-Landscape] High-fi StoryActivity Updated UI
d9068d7
anshbajpai pushed a commit to anshbajpai/oppia-android that referenced this issue Feb 11, 2021
Fix oppia#2093 Code Formatting Improved
3a34b0d
@anshbajpai anshbajpai mentioned this issue Feb 11, 2021
Closed
8 tasks
anshbajpai pushed a commit to anshbajpai/oppia-android that referenced this issue Feb 11, 2021
Fix oppia#2093 - Linting issue fixes
67fc43e
anshbajpai pushed a commit to anshbajpai/oppia-android that referenced this issue Feb 11, 2021
Fix oppia#2093 Shifted Code, using databinding only
61ec1c8
@rt4914
Copy link
Contributor Author

rt4914 commented Mar 31, 2021

@Amar-2003 Which progress bar? The mock does not contain any bar in this.
Also I think the mocks have changed slightly so will inform Chantel to update them.
@mschanteltc I think this mock needs to be updated: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/cce938d6-e079-4761-bac0-8bde22ac6348/
This should match with the text of inactive card in this mock: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/5abb0ace-19ee-48b8-8154-919154f924d2/
Also, just for consistency can you check tablet mocks too if they need any change or not?

Just to make sure, are we able to create the "scroll to" action when the chapter name is tapped on? The animation can been seen in the portrait mobile mock when "Chapter 2: The Meaning of 'Equal Parts'" is tapped on from the Chapter 3 card.

@mschanteltc Yes we can do the scroll to action.

@mschanteltc
Copy link

@mschanteltc Yes we can do the scroll to action.

Sounds good, I update the landscape mock and applied the change elsewhere in the original portrait mocks. Let me know what you think!

@rt4914
Copy link
Contributor Author

rt4914 commented Mar 31, 2021

@Amar-2003 You can now work on this new mock.

@E13ctron
Copy link
Contributor

E13ctron commented Apr 1, 2021

@rt4914 I will go through the mocks and will inform you when I am ready to do it :).

@E13ctron
Copy link
Contributor

E13ctron commented Apr 2, 2021

The current screen is like this right??
Screenshot_20210402-081717_Oppia
And I will have to change it into as in mock right ?? @rt4914

@E13ctron
Copy link
Contributor

E13ctron commented Apr 3, 2021

The current screen is like this right??
Screenshot_20210402-081717_Oppia
And I will have to change it into as in mock right ?? @rt4914

@rt4914

1 similar comment
@E13ctron
Copy link
Contributor

E13ctron commented Apr 5, 2021

The current screen is like this right??
Screenshot_20210402-081717_Oppia
And I will have to change it into as in mock right ?? @rt4914

@rt4914

@rt4914
Copy link
Contributor Author

rt4914 commented Apr 7, 2021

@Amar-2003 Yes you need to change this as per mocks.

@E13ctron
Copy link
Contributor

E13ctron commented Apr 7, 2021 •
edited
Loading

@rt4914 I may not be able to do this as I am busy with exams, so if someone else comes you may assign this to them or if none comes I will claim later

@jonathanalvares9009
Copy link
Contributor

@rt4914 the mock is not loading

@jonathanalvares9009 jonathanalvares9009 self-assigned this Apr 13, 2021
@anandwana001
Copy link
Contributor

@jonathanalvares9009 any update on this?
The mock is opening for me.

@rt4914
Copy link
Contributor Author

rt4914 commented May 6, 2021

@rt4914 the mock is not loading

@jonathanalvares9009 It is loading for me. Can you please retry?

@anandwana001
Copy link
Contributor

unassigning as no further update

@rt4914 rt4914 self-assigned this May 25, 2021
@veena14cs
Copy link
Contributor

veena14cs commented Jul 6, 2021 •
edited
Loading

Note : Please test UI for RTL support, prior to merging this fix.

@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 12, 2021
@rt4914 rt4914 moved this from Needs Triage to Beta (Bugs & Fixes) in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@rt4914 rt4914 moved this from Beta (Bugs & Fixes) to High-fi Beta in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@rt4914 rt4914 assigned viktoriias and unassigned rt4914 Sep 4, 2021
@viktoriias
Copy link
Contributor

RTL support was fixed in #3656.

@viktoriias viktoriias mentioned this issue Sep 16, 2021
Merged
6 tasks
@viktoriias
Copy link
Contributor

@rt4914 Are the mock in the description most current?

CLAM Team (deprecated -- please use new board) automation moved this from [Beta] Low-fi & High-fi to Closed Sep 21, 2021
rt4914 pushed a commit that referenced this issue Sep 21, 2021
@viktoriias @Viktoriia-Lozova
Fix #2093: [Mobile-Landscape] High-fi StoryActivity Updated UI (#3802)
87125aa 
* Add stroke.

* Grey border for locked chapters.

Co-authored-by: viktoriia <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktoriias viktoriias

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
CLAM Team (deprecated -- please use n...
Closed
Milestone
No milestone