Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file formatting under multiplechoiceinput package #2037

Closed
anandwana001 opened this issue Oct 24, 2020 · 1 comment · Fixed by #2049
Closed

Fix file formatting under multiplechoiceinput package #2037

anandwana001 opened this issue Oct 24, 2020 · 1 comment · Fixed by #2049
Assignees
@Arjupta
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@anandwana001
Copy link
Contributor

Describe the bug
All the files, under the package domain/src/test/java/org/oppia/android/domain/classify/rules/multiplechoiceinput are not in the correct format.

Expected behavior
File format should be follow from this file - TextInputEqualsRuleClassifierProviderTest

Correct Order
Constant values
Dagger injection
Local variables
Test Before setup
Tests
Dagger Setup
@Arjupta Arjupta self-assigned this Oct 26, 2020
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Oct 27, 2020
@Arjupta
Fix oppia#2037: file formatting under multiplechoiceinput package
c3f3061 
Removed the oneline functions to segregate the initialisation logic in the starting of file
@Arjupta Arjupta mentioned this issue Oct 27, 2020
Merged
8 tasks
@Arjupta
Copy link
Contributor

Arjupta commented Oct 28, 2020

@aggarwalpulkit596 this issue doesn't have any points associated with it. Can you assign some points on the basis of PR.

@rt4914 rt4914 added the SLoP-5 label Oct 28, 2020
rt4914 pushed a commit that referenced this issue Oct 29, 2020
@Arjupta
Fix #2037: file formatting under multiplechoiceinput package (#2049)
7a2a6f7 
* Fix #2037: file formatting under multiplechoiceinput package

Removed the oneline functions to segregate the initialisation logic in the starting of file

* Edits suggested by @anandwana001

* Edits of Indentation and Renamed Variables

* Edits for changed variable names

* Corrected the failing lint check
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjupta Arjupta

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2037: file formatting under multiplechoiceinput package Arjupta/oppia-android
4 participants
@rt4914 @BenHenning @anandwana001 @Arjupta