Rename package #1833
Assignees
Labels
Priority: Important
This work item is really important to complete for its milestone, but it can be scoped out.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Projects
Milestone
Comments
BenHenning
added
Type: Improvement
Priority: Important
This was referenced Sep 24, 2020
BenHenning
added a commit
that referenced
this issue
Sep 24, 2020
* Move all source files to new org/oppia/android directory structure. No actual package or code references are updated yet. * Update Kotlin & XML references to match new package structure. * Migrate codepaths for Bazel builds to new package structure. * Fix package references in Gradle files for new package structure. * Update package & pathing references to new structure for proto files. * Rename Android package to org.oppia.android. This includes introducing a new developer Firebase project. It also fixes references to Android resource R file imports & databinding since they both exist at the package level rather than the app module level. * Fix Bazel builds for new package structure. This required some changes to test setup/arrangement in Bazel, and some existing issues needed to be fixed (missing dependencies for work manager, switching multidex, one renamed test, incorrect module references in tests, and files now referencing resources needing to be moved). This includes some Bazel file reformatting that happened automatically by my Bazel file plugin. * Resolve merge conflicts. This won't compile due to duplicate imports which requires a ktlint clean-up. That will happen in a subsequent commit since it will likely pick up unrelated changes. * Remove some merge conflict markers that were missed. * Remove redundant commits & other ktlint updates. * Fix incorrect references to new testing package location. * Post-testing module cleanups via ktlint. * More post-merge fixes. Fix new references to R and databinding. Move EditTextInputAction to correct package. * Move some missed files that only caused breakages in Bazel. * Move all files to their correct new location. This moves all Kotlin source files to be under an org.oppia.android structure, but does not actually change references. This is done in two steps to try and preserve history, and to simplify the code review. THIS WILL BREAK THE CODEBASE WHEN CHECKED IN. * Fix missed files from the migration after merging. * Disable Firebase data collection. * Update BUILD.bazel Capitalize TODO comment for consistency with other TODO comments.
prayutsu
pushed a commit
to prayutsu/oppia-android
that referenced
this issue
Sep 25, 2020
…#1876) * Move all source files to new org/oppia/android directory structure. No actual package or code references are updated yet. * Update Kotlin & XML references to match new package structure. * Migrate codepaths for Bazel builds to new package structure. * Fix package references in Gradle files for new package structure. * Update package & pathing references to new structure for proto files. * Rename Android package to org.oppia.android. This includes introducing a new developer Firebase project. It also fixes references to Android resource R file imports & databinding since they both exist at the package level rather than the app module level. * Fix Bazel builds for new package structure. This required some changes to test setup/arrangement in Bazel, and some existing issues needed to be fixed (missing dependencies for work manager, switching multidex, one renamed test, incorrect module references in tests, and files now referencing resources needing to be moved). This includes some Bazel file reformatting that happened automatically by my Bazel file plugin. * Resolve merge conflicts. This won't compile due to duplicate imports which requires a ktlint clean-up. That will happen in a subsequent commit since it will likely pick up unrelated changes. * Remove some merge conflict markers that were missed. * Remove redundant commits & other ktlint updates. * Fix incorrect references to new testing package location. * Post-testing module cleanups via ktlint. * More post-merge fixes. Fix new references to R and databinding. Move EditTextInputAction to correct package. * Move some missed files that only caused breakages in Bazel. * Move all files to their correct new location. This moves all Kotlin source files to be under an org.oppia.android structure, but does not actually change references. This is done in two steps to try and preserve history, and to simplify the code review. THIS WILL BREAK THE CODEBASE WHEN CHECKED IN. * Fix missed files from the migration after merging. * Disable Firebase data collection. * Update BUILD.bazel Capitalize TODO comment for consistency with other TODO comments.
BenHenning
added
the
Z-ibt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per discussion during meeting, we need to rename the app package & Kotlin packages to org.oppia.android.
Need to also rename the packages for Firebase projects.
The text was updated successfully, but these errors were encountered: