Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate data module off of Moshi #1600

Closed
miaboloix opened this issue Aug 10, 2020 · 0 comments · Fixed by #3025
Closed

Migrate data module off of Moshi #1600

miaboloix opened this issue Aug 10, 2020 · 0 comments · Fixed by #3025
Assignees
@BenHenning
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Bazel Migration

Comments

@miaboloix
Copy link
Contributor

No description provided.

@miaboloix miaboloix self-assigned this Aug 10, 2020
@miaboloix miaboloix added this to To do: Stage 1 in Bazel Migration Aug 10, 2020
@miaboloix miaboloix added this to the Stage 1 of Bazel Migration milestone Aug 10, 2020
@BenHenning BenHenning modified the milestones: Stage 1 of Bazel Migration, Stage 2 of Bazel Migration Aug 25, 2020
@BenHenning BenHenning assigned BenHenning and unassigned miaboloix Feb 19, 2021
@BenHenning BenHenning mentioned this issue Feb 19, 2021
Closed
@BenHenning BenHenning mentioned this issue Mar 30, 2021
Merged
BenHenning added a commit that referenced this issue Mar 31, 2021
@BenHenning
[RunAllTests] Fix #3018, #1675, #2931, #1600, and part of #2642: Enab…
8b1335f 
…le data module in Bazel (#3025)

* Enable Moshi support in Bazel.

This includes some reorganizing of the data module, but it introduces
support for generating GAE models through Moshi. Corresponding mock
services & tests are still failing, but //data & //:oppia build.

* Make mock services build for testing module.

* Add working data tests to Bazel build.

This also fixes a regression from an earlier commit that led to the
Moshi objects not actually being generated correctly, so the data
service tests are good proof that Moshi is being used correctly.

* Remove TODOs for #1675.

* Lint fixes.

* Bazel lint fix.

Avoid relying on native java_library.

* Fix broken Gradle build.

This includes explicitly specifying okhttp version since Gradle was
previously randomly picking one.

* Add debug details for affected tests script.

* Lint fixes.

* Attempt to force Bazel cache to clear.

This is an attempt to work around a theorized OOM happening when trying
to compute the sibling build graph for changes build files.

* Post-merge fix.

* Fix another post-merge failure.

This regressed in a recent PR likely due to other Bazel failures hiding
it in CI.

* Upgrade to Robolectric 4.4.

This also moves off of Oppia's fork of robolectric-bazel.

* Switch TopicRevisionFragmentTest to test image loaders.

The test should have been using them before, but this might have been
missed. The test image loaders are necessary in the Robolectric test
environment, and something about Robolectric 4.4 + Bazel specifically
exposed this.
@seanlip seanlip moved this from To do: to Done in Bazel Migration Aug 12, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Task Force] Migrate to Bazel - Android
Archived in project
Bazel Migration
  
Done
Milestone
No milestone
2 participants
@BenHenning @miaboloix