Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[52555] Add searchbar to Submenu component #15800

Merged

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Jun 10, 2024

ToDo

  • Add an option to display a "search" input the SubMenu component
    • Extract logic of filtering used for projectAttribute list (in the project settings) into a reusable controller
    • Use that generic controller inside the SubMenu component
    • When there are no results, show a generic info text
  • Enable the search functionality on the project list page

cleanup

  • I moved the existing filters.controller to a separate filter folder and renamed it to filters-form.controller

https://community.openproject.org/projects/openproject/work_packages/52555/activity

@HDinger HDinger added this to the 14.3.x milestone Jun 10, 2024
@HDinger HDinger force-pushed the feature/52555-add-searchbar-to-submenu-component-2 branch 3 times, most recently from 7a3173d to a3aea59 Compare June 11, 2024 09:37
…ter controller. Therefore, a separate folder for the filter controllers was created and the previous `filtersController` was named more specific and moved to that folder.
@HDinger HDinger force-pushed the feature/52555-add-searchbar-to-submenu-component-2 branch 2 times, most recently from 9c59ce2 to fbfe39f Compare June 11, 2024 12:11
@HDinger HDinger force-pushed the feature/52555-add-searchbar-to-submenu-component-2 branch from 718bf2d to eaaef34 Compare June 12, 2024 09:00
@HDinger HDinger marked this pull request as ready for review June 12, 2024 09:00
@HDinger HDinger requested a review from a team June 12, 2024 09:00
@oliverguenther oliverguenther requested review from oliverguenther and removed request for a team June 12, 2024 19:04
@oliverguenther
Copy link
Member

In the current implementation used in work packages, groups without hits are hidden:
Bildschirmfoto 2024-06-13 um 08 50 53

This is no longer the case:
Bildschirmfoto 2024-06-13 um 08 51 07

I'm aware that the implementation you chose might make it quite hard to allow this to happen in the new groups as well, I just wanted to raise it.

Code-wise, LGTM 👍

Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll accept the difference in behavior for now, and check with the designers

@oliverguenther oliverguenther merged commit f672afc into dev Jun 13, 2024
11 checks passed
@oliverguenther oliverguenther deleted the feature/52555-add-searchbar-to-submenu-component-2 branch June 13, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants