Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add migration requirements for manta-rs #36

Merged
merged 40 commits into from
Dec 16, 2022
Merged

feat: add migration requirements for manta-rs #36

merged 40 commits into from
Dec 16, 2022

Conversation

bhgomes
Copy link
Member

@bhgomes bhgomes commented Dec 7, 2022 •
edited by GhostOfGauss
Loading

Signed-off-by: Brandon H. Gomes [email protected]

Check that this PR works before merging: Manta-Network/manta-rs#292

  • Add Dalek Plugin
  • Fix accumulator issue
  • Add Merkle tree impl
  • Move openzl_util::num impls from manta-rs
  • Add UnsafeNoEncrypt
  • Add ark-poly and ark-std to openzl-plugin-arkworks (solved by Import Poseidon #34)
  • Add Groth16 impl

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate L- label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes mentioned this pull request Dec 7, 2022
Draft
9 tasks
GhostOfGauss and others added 16 commits December 8, 2022 10:55
@bhgomes bhgomes mentioned this pull request Dec 9, 2022
Closed
4 tasks
@GhostOfGauss GhostOfGauss added the L-added Changelog: add these changes to the `added` section of the changelog label Dec 12, 2022
@GhostOfGauss GhostOfGauss marked this pull request as ready for review December 12, 2022 17:09
GhostOfGauss
GhostOfGauss reviewed Dec 13, 2022
View reviewed changes
openzl-crypto/src/accumulator.rs Show resolved Hide resolved
openzl-crypto/src/merkle_tree/mod.rs Show resolved Hide resolved
openzl-crypto/src/merkle_tree/tree.rs Outdated Show resolved Hide resolved
openzl-crypto/src/merkle_tree/node.rs Show resolved Hide resolved
openzl-crypto/src/merkle_tree/tree.rs Outdated Show resolved Hide resolved
openzl-crypto/src/merkle_tree/node.rs Show resolved Hide resolved
openzl-crypto/src/merkle_tree/inner_tree.rs Show resolved Hide resolved
openzl-crypto/src/merkle_tree/partial.rs Show resolved Hide resolved
openzl-crypto/src/merkle_tree/path.rs Show resolved Hide resolved
openzl-crypto/src/merkle_tree/path.rs Show resolved Hide resolved
@GhostOfGauss GhostOfGauss self-requested a review December 14, 2022 18:36
GhostOfGauss
GhostOfGauss previously approved these changes Dec 14, 2022
View reviewed changes
@bhgomes @GhostOfGauss
Update openzl-crypto/src/merkle_tree/tree.rs
f3ea221 
Co-authored-by: Todd Norton <[email protected]>
Signed-off-by: Brandon H. Gomes <[email protected]>
GhostOfGauss
GhostOfGauss previously approved these changes Dec 15, 2022
View reviewed changes
SupremoUGH
SupremoUGH requested changes Dec 16, 2022
View reviewed changes
openzl-crypto/src/encryption/mod.rs Show resolved Hide resolved
openzl-crypto/src/encryption/mod.rs Show resolved Hide resolved
openzl-crypto/src/encryption/mod.rs Outdated Show resolved Hide resolved
openzl-crypto/src/encryption/mod.rs Show resolved Hide resolved
openzl-crypto/src/lib.rs Show resolved Hide resolved
openzl-crypto/src/merkle_tree/test.rs Show resolved Hide resolved
plugins/arkworks/src/constraint/fp.rs Outdated Show resolved Hide resolved
plugins/arkworks/src/groth16.rs Show resolved Hide resolved
plugins/dalek/Cargo.toml Show resolved Hide resolved
plugins/dalek/src/ed25519.rs Show resolved Hide resolved
This was referenced Dec 16, 2022
Open
Open
@bhgomes
fix: resolve review comments
b961957 
Signed-off-by: Brandon H. Gomes <[email protected]>
@bhgomes
chore: fix import issue
fe1697e 
Signed-off-by: Brandon H. Gomes <[email protected]>
@SupremoUGH SupremoUGH merged commit ce5a07d into main Dec 16, 2022
@SupremoUGH SupremoUGH deleted the feat/migrate-openzl branch December 16, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupremoUGH SupremoUGH SupremoUGH approved these changes

@GhostOfGauss GhostOfGauss GhostOfGauss approved these changes

Assignees
No one assigned
Labels
L-added Changelog: add these changes to the `added` section of the changelog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhgomes @SupremoUGH @GhostOfGauss