Fixes bad parse of parent w/o sampling and backfills logging tests #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One case failed to parse, which is not-yet-sampled header that includes
a parent ID. This is malpractice, but shouldn't fail to parse. This
fixes it.
This also corrects the log statements for some things and tests them.
Coming out of envoyproxy/envoy#4712 (comment)
@zyfjeff noticed our logs were misleading on incorrect data like putting an exclamation point where a hyphen should be. I was lazy and didn't assert on logs.. now .. yeah will do that :P
Thanks to @zyfjeff cc @shakuzen