Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation message #2

Merged
merged 2 commits into from
Sep 10, 2015

Conversation

jcarres-mdsol
Copy link

Pointing users to the right gem

@jamescway @adriancole

@codefromthecrypt
Copy link

Thanks for doing this.. I'd move the deprecated to the top of the file and separate the rest with a line?

@jcarres-mdsol
Copy link
Author

@adriancole done

@codefromthecrypt
Copy link

sorry for the nit.. instead of adding blank lines, maybe make a horizontal line like this?
* * *
renders like this:


@jcarres-mdsol
Copy link
Author

The three *** together in line 9 should be rendering that line also

codefromthecrypt pushed a commit that referenced this pull request Sep 10, 2015
@codefromthecrypt codefromthecrypt merged commit fdf4296 into openzipkin-attic:master Sep 10, 2015
@codefromthecrypt
Copy link

ps should we rename the repo to deprecated-faraday-zipkin?

@jcarres-mdsol
Copy link
Author

Renaming the repo would break Gemfiles which are referencing Github directly. Sure then they will very much notice stuff have been deprecated 😆

@codefromthecrypt
Copy link

ok maybe rename after we have a release or two :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants