Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/memory leaks #487

Merged
merged 15 commits into from
Sep 25, 2023
Merged

Fix/memory leaks #487

merged 15 commits into from
Sep 25, 2023

Conversation

andycall
Copy link
Member

@andycall andycall commented Sep 19, 2023 •
edited
Loading

Fixed #482

Fixed the memory leaks caused by the UICommand::disposedBindingObject command not being executed.

These memory leaks affected versions 0.14.1 to 0.15.0 and 0.13.3

@andycall andycall mentioned this pull request Sep 19, 2023
Closed
1 task
XGHeaven
XGHeaven requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@XGHeaven XGHeaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the better to change the title to a good one.

webf/lib/src/bridge/to_native.dart Outdated Show resolved Hide resolved
@zjt123
Copy link
Contributor

zjt123 commented Sep 20, 2023

这个是否能弄个测试用例，便于自测及时发现问题

@andycall
Copy link
Member Author

@zjt123 added

@andycall andycall force-pushed the fix/memory_leaks branch 4 times, most recently from bf92997 to b56d5e0 Compare September 23, 2023 11:08
@andycall andycall added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 18c94b7 Sep 25, 2023
24 checks passed
@andycall andycall deleted the fix/memory_leaks branch September 25, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjt123 zjt123 zjt123 approved these changes

@XGHeaven XGHeaven XGHeaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

内存占用严重，不释放
3 participants
@andycall @zjt123 @XGHeaven