Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fix css vars() and calc() in some user cases. #355

Merged
merged 4 commits into from
May 25, 2023
Merged

Fix: fix css vars() and calc() in some user cases. #355

merged 4 commits into from
May 25, 2023

Conversation

andycall
Copy link
Member

  1. Fix set CSS var on :root not working when adding stylesheet with <style /> elements.
  2. Fix calc not working when combine with vars.
  3. Add support for --color: rgba(var(--color-value)) and --color: hsl(var(--color-value)).

@yifei8 yifei8 added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit 302d80e May 25, 2023
@yifei8 yifei8 deleted the fix/css_vars branch May 25, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devjiangzhou devjiangzhou devjiangzhou approved these changes

@yifei8 yifei8 yifei8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andycall @devjiangzhou @yifei8