feat: add basic svg element #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b09fb46
to
3fb2802
Compare
3fb2802
to
a1ee468
Compare
andycall
reviewed
Mar 30, 2023
2cb5647
to
6b16fba
Compare
975f852
to
2c95a19
Compare
8c7bbf7
to
5049928
Compare
andycall
reviewed
Apr 27, 2023
andycall
reviewed
Apr 27, 2023
4d67adc
to
1d32e9c
Compare
andycall
reviewed
May 8, 2023
andycall
reviewed
May 8, 2023
Support the basic usage of svg to render icon.
More implements will be add in the future.
- SVG element support presentation attributes
- New style add
- [x] `fill` (partial test)
- [x] `stroke` (partial test)
- [x] `x` (non test)
- [x] `y` (non test)
- [x] `fill-rule` (full test with `<path>`)
- [x] `stroke-width` (partial test)
- [x] `stroke-linecap` (full test with `<path>`)
- [x] `stroke-linejoin` (full test with `<path>`)
- Element
- [x] `<svg>` (non tests, added in the future)
- [x] `<rect>` (partial tests, just used for test <path>)
- [x] `<path>`
- [x] `d` full test
- [x] `<text>` (non tests, added in the future)
- [x] `<g>` (non tests, added in the future)
- DOM Interface (non tests, just a empty class)
- [x] `SVGElement`
- [x] `SVGRectElement`
- [x] `SVGGElement`
- [x] `SVGTextElement`
- [x] `SVGPathElement`
- [x] And other super classess..
- Integration Test
- [x] Add SVG spec group.
- [x] Add `svg_loader` to compile svg test file.
- [x] Add `resizeViewport` function to resize the viewport.
Because some svg test file needs the larger viewport.
- [x] `toMatchSnapshot` support accept blob file to compare.
No png file generated.
- [x] Add `getSnapshot`/`cacheSnapshot`/`matchCacheSnapshot` function
to implement compare the snapshots of two frame.
1 task
andycall
approved these changes
May 13, 2023
xuzhongpeng
approved these changes
May 14, 2023
xuzhongpeng
approved these changes
May 14, 2023
xuzhongpeng
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the basic usage of svg to render icon.
More implements will be add in the future.
fill(partial test)stroke(partial test)x(non test)y(non test)fill-rule(full test with<path>)stroke-width(partial test)stroke-linecap(full test with<path>)stroke-linejoin(full test with<path>)<svg>(non tests, added in the future)<rect>(partial tests, just used for test )<path>dfull test<text>(non tests, added in the future)<g>(non tests, added in the future)SVGElementSVGRectElementSVGGElementSVGTextElementSVGPathElementsvg_loaderto compile svg test file.resizeViewportfunction to resize the viewport.Because some svg test file needs the larger viewport.
toMatchSnapshotsupport accept blob file to compare.No png file generated.
getSnapshot/cacheSnapshot/matchCacheSnapshotfunctionto implement compare the snapshots of two frame.