-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: redesign bridge code base #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c55a19f
to
c0e64e6
Compare
c0e64e6
to
03a87cc
Compare
8a5e4d5
to
0b35f50
Compare
23c1b81
to
d8a5f14
Compare
d774707
to
5c9554c
Compare
21dd6ee
to
8cf26ff
Compare
Beta/0.13.0
…_parse_html fix: should flush ui command before evaluate script when parse html.
XGHeaven
requested changes
Oct 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bridge/third_party/quickjs/quickjs.c
file is empty, remove it.- The integration snapshot files about
hsl
/hsla
should not be added. Maybe rebase the main branch and rerun to fix it.
(PS: 实在是看不懂,只能 re 出一些无关紧要的东西了)
0b036d3
to
b88c8b5
Compare
pba-cra
approved these changes
Oct 21, 2022
devjiangzhou
approved these changes
Oct 21, 2022
1 task
1 task
looseyi
pushed a commit
that referenced
this pull request
May 29, 2024
[0.14.2][Android] [fix]: fix double click issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete re-design the code base of bridge, fix hard-core problems and improve the performance.
Note: this PR removed 95% of original bridge's code.
The hard-core problems in bridge:
Performance improvement
The new design:
core
andbindings
directory. core aims to DOM and Web API, bindings aims to all interactions to QuickJS API.Design Notes:
Split out core and interface
Type kind conversion with TypeScript and C++.
Based on the type define in TypeScript typings and generated the corresponding C++ call code. The call code are formed by C++
Converter
class, responsible to easy convert any JS kind to C++ kind.TSOptional<TSDouble>
TSNullable<TSDouble>
TSSequence<TSDouble>
Example:
How properties and methods defined
JS code use prototype to access native defined properties and methods.