GTEST/UCT: Unit tests for UMR XGVMI #9838
Merged
+251
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvegas1
reviewed
Apr 22, 2024
tvegas1
reviewed
Apr 22, 2024
brminich
reviewed
Apr 22, 2024
test/gtest/uct/ib/test_devx.cc
Outdated
| destroy_memh(imported_memh2); | ||
| destroy_memh(exported_memh); | ||
| } | ||
|
|
||
| UCT_INSTANTIATE_IB_TEST_CASE(test_devx); |
There was a problem hiding this comment.
pls move it before the new class, typically we initialize test classes right after their (and their tests) definitions
tvegas1
reviewed
Apr 22, 2024
brminich
previously approved these changes
Apr 23, 2024
tvegas1
previously approved these changes
Apr 23, 2024
yosefe
reviewed
May 5, 2024
test/gtest/uct/ib/test_devx.cc
Outdated
| destroy_memh(memh); | ||
|
|
||
| /* After release of memh, associated UMR mkey is moved back to mkey pool */ | ||
| ASSERT_EQ(check_xgvmi() ? 1 : 0, ucs_list_length(&md()->umr.mkey_pool)); |
There was a problem hiding this comment.
Here I wanted to check that releasing of memory handle triggers invalidation of associated UMR mkey, that must be returned to the UMR mkey pool. Again, we check it for both flows, truly-xgvmi and fake-xgvmi devices
|
/azp run UCX PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yosefe
reviewed
May 22, 2024
test/gtest/uct/ib/test_devx.cc
Outdated
| * ones, given jitter we check that it's at least 50 times faster */ | ||
| ASSERT_GT(export_create_time / 50, export_reuse_time); | ||
| ASSERT_GT(import_create_time / 50, import_reuse_time); | ||
| UCS_TEST_MESSAGE << "Export create time: " << export_create_time; |
There was a problem hiding this comment.
IMO we can print it in a more compact way + convert to milliseconds
There was a problem hiding this comment.
Ok, now it's in this format:
[ INFO ] Create 1000 UMR mkeys, export: 397.802 ms, import: 215.757 ms
[ INFO ] Reuse 1000 UMR mkeys, export: 1.784 ms, import: 0.421 ms
yosefe
reviewed
May 23, 2024
test/gtest/uct/ib/test_devx.cc
Outdated
| EXPECT_LT(export_reuse_time, export_create_time / 10); | ||
|
|
||
| char buf[1024] = {}; | ||
| sprintf(buf, "Create %zu UMR mkeys, export: %.3f ms, import: %.3f ms", |
There was a problem hiding this comment.
snprintf / ucs_snprintf_safe
test/gtest/uct/ib/test_devx.cc
Outdated
| MEMH_COUNT, ucs_time_to_msec(export_create_time), | ||
| ucs_time_to_msec(import_create_time)); | ||
| UCS_TEST_MESSAGE << buf; | ||
| sprintf(buf, "Reuse %zu UMR mkeys, export: %.3f ms, import: %.3f ms", |
There was a problem hiding this comment.
snprintf / ucs_snprintf_safe
yosefe
approved these changes
May 24, 2024
iyastreb
force-pushed
the
uct/gtest/umr-xgvmi
branch
from
480d07a
to
5873fa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Few unit tests for XGVMI UMR approach to check that:
We introduce new config option UCX_XGVMI_UMR_ENABLE option as a part of this commit, which enables XGVMI UMR workflow.