Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring web operation name handler #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zouyx
Copy link

@zouyx zouyx commented Dec 14, 2020

1.Support Spring RequestMapping
2.HandlerUtils.requestMapping,if use .path()can not get anything when use @Requestmapping
so change to value()

@geoand
Copy link
Collaborator

geoand commented Dec 14, 2020

Hi,

Thanks for the contribution.

Can you please explain the rationale behind these changes?

@zouyx
Copy link
Author

zouyx commented Dec 15, 2020

Hi,

Thanks for the contribution.

Can you please explain the rationale behind these changes?

Relate to #115 which can not run travis CI.

Just recreate it.

@geoand
Copy link
Collaborator

geoand commented Dec 15, 2020

I see thanks.

Could you please add a test as was requested in the original PR?

@zouyx
Copy link
Author

zouyx commented Dec 15, 2020

I see thanks.

Could you please add a test as was requested in the original PR?

I think will add it in this few day

@zeitlinger
Copy link

@zouyx not sure I understand this PR correctly. Is this about changing the operation name to be something more meaningful than GET?

@zouyx
Copy link
Author

zouyx commented Apr 17, 2021

@zouyx not sure I understand this PR correctly. Is this about changing the operation name to be something more meaningful than GET?

yes, you are right. because it can not get anything when use @RequestMapping

@zeitlinger
Copy link

Fixes #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants