-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(policy): 1398 add metadata support to Resource Mapping Groups #1412
Merged
ryanulit
merged 10 commits into
main
from
feat/1398-resource-mapping-groups-include-metadata
Sep 4, 2024
Merged
feat(policy): 1398 add metadata support to Resource Mapping Groups #1412
ryanulit
merged 10 commits into
main
from
feat/1398-resource-mapping-groups-include-metadata
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
reviewed
Aug 26, 2024
service/policy/db/migrations/20240821000000_add_res_map_groups_metadata_field.sql
Outdated
Show resolved
Hide resolved
jakedoublev
reviewed
Aug 26, 2024
This looks good to me. ✅ when release freeze is ended. |
jakedoublev
approved these changes
Sep 4, 2024
ryanulit
deleted the
feat/1398-resource-mapping-groups-include-metadata
branch
September 4, 2024 16:22
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.15](protocol/go/v0.2.14...protocol/go/v0.2.15) (2024-09-04) ### Features * **policy:** 1398 add metadata support to Resource Mapping Groups ([#1412](#1412)) ([87b7b2f](87b7b2f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.24](service/v0.4.23...service/v0.4.24) (2024-10-01) ### Features * **ci:** run otdfctl e2e tests within platform ([#1526](#1526)) ([8240645](8240645)), closes [#1528](#1528) * **core:** Ability to add namespace level loggers ([#1537](#1537)) ([bd57070](bd57070)) * **policy:** 1370 add audit support for Resource Mapping Groups ([#1418](#1418)) ([57dc217](57dc217)), closes [#1370](#1370) * **policy:** 1398 add metadata support to Resource Mapping Groups ([#1412](#1412)) ([87b7b2f](87b7b2f)) * **policy:** 1426 tech debt migrate Namespace object queries to sqlc ([#1432](#1432)) ([6bde0ab](6bde0ab)), closes [#1426](#1426) * **policy:** 1509 add readme on arch decisions of policy service ([#1508](#1508)) ([71b49ec](71b49ec)), closes [#1509](#1509) * **policy:** 1552 implement recommended changes to audit process ([#1588](#1588)) ([aabc5cb](aabc5cb)) * **policy:** generate policy ERD ([#1525](#1525)) ([8eb322b](8eb322b)) ### Bug Fixes * **core:** Add NanoTDF KID padding removal and update logging level ([#1466](#1466)) ([54de8f4](54de8f4)), closes [#1467](#1467) * **core:** Autobump service ([#1514](#1514)) ([2b9aa6d](2b9aa6d)) * **core:** Autobump service ([#1599](#1599)) ([93646d7](93646d7)) * **core:** Fix parsing /v1/authorization ([#1554](#1554)) ([b7d694d](b7d694d)), closes [#1553](#1553) * **core:** Fix POST /v1/entitlements body parsing ([#1574](#1574)) ([fcae7ef](fcae7ef)) * **core:** let service start fail if port not free ([#1504](#1504)) ([708d15d](708d15d)) * **policy:** ensure LIST namespace grants excludes fqns for defs/vals ([#1478](#1478)) ([243c51c](243c51c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1398
Implements new migration to add
resource_mapping_groups.metadata
column and updates protos, sqlc queries and DB logic to use it