Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flavor metrics #297

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Fix flavor metrics #297

merged 3 commits into from
Sep 15, 2023

Conversation

odnobit
Copy link
Contributor

@odnobit odnobit commented Aug 29, 2023

nova_flavor metrics fix

  • nova_flavor metrics were collecting incorrectly because the AccessType parameter wasn't added.
    openstack_exporter was only collecting flavors from the current project.
  • Also, the fixtures/nova_os_flavors.json has been changed to correct one.

@odnobit
Copy link
Contributor Author

odnobit commented Aug 29, 2023

@niedbalski greetings!
please check, if you could.

@niedbalski niedbalski self-requested a review August 29, 2023 10:38
@odnobit
Copy link
Contributor Author

odnobit commented Aug 31, 2023

@niedbalski hello! what do u think about changes?

niedbalski
niedbalski approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@niedbalski niedbalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niedbalski niedbalski merged commit ecd82ed into openstack-exporter:main Sep 15, 2023
6 checks passed
@odnobit odnobit deleted the fix_flavor_metrics branch September 18, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niedbalski niedbalski niedbalski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odnobit @niedbalski