Update logging and dependencies #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedbalski
requested changes
Aug 23, 2023
exporters/exporter.go
Outdated
| @@ -176,7 +178,7 @@ func (exporter *BaseOpenStackExporter) AddMetric(name string, fn ListFunc, label | |||
| // @TODO: get the region. constLabels["region"] = exporter. | |||
|
|
|||
| if _, ok := exporter.Metrics[name]; !ok { | |||
| log.Infof("Adding metric: %s to exporter: %s", name, exporter.Name) | |||
| // log.Infof("Adding metric: %s to exporter: %s", name, exporter.Name) | |||
* Remove deprecated dependency github.com/prometheus/common/log and replace with github.com/go-kit/log * Update dependencies to the latest version
* Replace the landing page with the default landing page generated by the prometheus exporter toolkit
* Update the server handling to use the prometheus exporter toolkit This enables also the experimental tls support.
* Update the readme to include the current help output
Knalltuete5000
force-pushed
the
logging
branch
from
206f7d8
to
a003a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multiple changes to the exporter, but should not change the functionality of the exporter.
First of all this PR upgrades the dependencies and removes the deprecated log library form prometheus mentioned in #256. It will be replaced with the github.com/go-kit/log library, which is used by other exporters, e.g. the smartctl_exporter or the node_exporter
Due to the switch of the logging library it is possible to upgrade the prometheus libraries to the current versions. This includes also scraping the exporter via tls.
In addition the landing page is replaced with the landing page provided by the github.com/prometheus/exporter-toolkit
NOTE: I have added a golangci configuration file to exclude the
.Log-method from checking the error returned. Please let me know if this is wanted or not. If not I will remove the configuration fill and work around the linting issues.